refactor surface

Author: jasonlmfong

Model-Modifier/src/scene/surface/Surface.cpp

@@ -130,7 +130,7 @@ glm::vec3 Surface::ComputeFaceNormal(FaceRecord face)
     glm::vec3 pos0 = m_Vertices[face.verticesIdx[0]].position;
     glm::vec3 pos1 = m_Vertices[face.verticesIdx[1]].position;
     glm::vec3 pos2 = m_Vertices[face.verticesIdx[2]].position;
-    return glm::normalize(glm::cross(pos1 - pos0, pos2 - pos0));
+    return ComputeFaceNormal(pos0, pos1, pos2);
 }
 
 glm::vec3 Surface::ComputeFaceNormal(glm::vec3 pos0, glm::vec3 pos1, glm::vec3 pos2)

Model-Modifier/src/scene/surface/Surface.h

@@ -1,8 +1,8 @@
 #pragma once
 
+#include <set>
 #include <vector>
 #include <unordered_map>
-#include <set>
 
 #include "../../external/glm/ext/vector_float3.hpp"
 #include "../../external/glm/ext/vector_uint2.hpp"

Model-Modifier/src/scene/surface/Surface_Loop.cpp

@@ -74,7 +74,8 @@ Object Surface::Loop()
     }
 
     // update old (even) vertices (per vertex)
-    for (unsigned int i = 0; i < m_Vertices.size(); i++)
+    unsigned int numVertices = static_cast<unsigned int>(m_Vertices.size());
+    for (unsigned int i = 0; i < numVertices; i++)
     {
         VertexRecord vert = m_Vertices[i];
         glm::vec3 vertPos = vert.position;