[lldb][Swift][NFC] Adjust GetFunctionDisplayName to take SymbolContext by reference

The API was changed upstream for the C++ plugin. This patch adjusts the
API implementation for Swift

Author: Michael137

lldb/source/Plugins/Language/Swift/SwiftLanguage.cpp

@@ -1699,54 +1699,54 @@ bool SwiftLanguage::IsUninitializedReference(ValueObject &valobj) {
 }
 
 bool SwiftLanguage::GetFunctionDisplayName(
-    const SymbolContext *sc, const ExecutionContext *exe_ctx,
+    const SymbolContext &sc, const ExecutionContext *exe_ctx,
     FunctionNameRepresentation representation, Stream &s) {
   switch (representation) {
   case Language::FunctionNameRepresentation::eName:
     // No need to customize this.
     return false;
   case Language::FunctionNameRepresentation::eNameWithNoArgs: {
-    if (!sc->function)
+    if (!sc.function)
       return false;
-    if (sc->function->GetLanguage() != eLanguageTypeSwift)
+    if (sc.function->GetLanguage() != eLanguageTypeSwift)
       return false;
     std::string display_name = SwiftLanguageRuntime::DemangleSymbolAsString(
-        sc->function->GetMangled().GetMangledName().GetStringRef(),
-        SwiftLanguageRuntime::eSimplified, sc, exe_ctx);
+        sc.function->GetMangled().GetMangledName().GetStringRef(),
+        SwiftLanguageRuntime::eSimplified, &sc, exe_ctx);
     if (display_name.empty())
       return false;
     s << display_name;
     return true;
   }
   case Language::FunctionNameRepresentation::eNameWithArgs: {
-    if (!sc->function)
+    if (!sc.function)
       return false;
-    if (sc->function->GetLanguage() != eLanguageTypeSwift)
+    if (sc.function->GetLanguage() != eLanguageTypeSwift)
       return false;
     std::string display_name = SwiftLanguageRuntime::DemangleSymbolAsString(
-        sc->function->GetMangled().GetMangledName().GetStringRef(),
-        SwiftLanguageRuntime::eSimplified, sc, exe_ctx);
+        sc.function->GetMangled().GetMangledName().GetStringRef(),
+        SwiftLanguageRuntime::eSimplified, &sc, exe_ctx);
     if (display_name.empty())
       return false;
     ExecutionContextScope *exe_scope =
         exe_ctx ? exe_ctx->GetBestExecutionContextScope() : NULL;
     const InlineFunctionInfo *inline_info = NULL;
     VariableListSP variable_list_sp;
     bool get_function_vars = true;
-    if (sc->block) {
-      Block *inline_block = sc->block->GetContainingInlinedBlock();
+    if (sc.block) {
+      Block *inline_block = sc.block->GetContainingInlinedBlock();
 
       if (inline_block) {
         get_function_vars = false;
-        inline_info = sc->block->GetInlinedFunctionInfo();
+        inline_info = sc.block->GetInlinedFunctionInfo();
         if (inline_info)
           variable_list_sp = inline_block->GetBlockVariableList(true);
       }
     }
 
     if (get_function_vars) {
       variable_list_sp =
-          sc->function->GetBlock(true).GetBlockVariableList(true);
+          sc.function->GetBlock(true).GetBlockVariableList(true);
     }
 
     if (inline_info) {

lldb/source/Plugins/Language/Swift/SwiftLanguage.h

@@ -64,7 +64,7 @@ class SwiftLanguage : public Language {
 
   bool IsUninitializedReference(ValueObject &valobj) override;
 
-  bool GetFunctionDisplayName(const SymbolContext *sc,
+  bool GetFunctionDisplayName(const SymbolContext &sc,
                               const ExecutionContext *exe_ctx,
                               FunctionNameRepresentation representation,
                               Stream &s) override;