Skip to content

Commit 35bebe6

Browse files
committed
DataSetQ Etc
make classes make it shorter start moving functionality to their proper place flesh out DataSetQ maak factory functies en ruim datasetpackage alvast beetje op Move label set stuff to ColumnQ from DataSetPackage and some related changes Fairly sure the whol beginLoadingData etc in DataSetPackage isnt really necessary anymore move more stuff to Filter add invalidation to Filter move LabelFilterGenerator to another spot also tightly integrate it with FilterQ etc fix some problems move more stuff from FilterModel to FilterQ cleanin more changes use set functions for deserializen etc stapjes fix errors merge Q classes into the base data classes move labelfiltergenerator to CommonData move some more files around meer fixes add dropped function back fix more things remove lots of _undoStack and more changes JASP compiles again jasp starts try and get the data to show data shows now compiles and mostly runs but complains about threads make sure data classes are moved to the main thread so qml etc can access it later without crying throw in an error ill just add the dataPkgRoles to the rolenames regardles of what each proxy thinks about it variables show up in lists, analyses work filters dont get run, but at least the proxy doesnt choke on it anymore make label editor seem to work again remove useless passtrhough on filtermodel filter shows use invalidation rfilter works labelfiltergenerator is generating once more make sure filter gets updated if constructorR gets changed clarify which labels are from column label order, or dataset order make column selection not crash debug purple! make editable just change visibity instead of the color
1 parent e4c6f95 commit 35bebe6

File tree

134 files changed

+2929
-2955
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

134 files changed

+2929
-2955
lines changed

Common/enginedefinitions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ DECLARE_ENUM(performType, run, abort, saveImg, editImg, rewriteImgs);
1313
DECLARE_ENUM(analysisResultStatus, validationError, fatalError, imageSaved, imageEdited, imagesRewritten, complete, running, changed, waiting);
1414
DECLARE_ENUM(moduleStatus, initializing, installNeeded, loading, readyForUse, error);
1515
DECLARE_ENUM(engineAnalysisStatus, empty, toRun, running, changed, complete, error, exception, aborted, stopped, saveImg, editImg, rewriteImgs, synchingData);
16-
DECLARE_ENUM(enginesListRoles, channel = 257, module, engineState, analysisStatus, runsWhat, running, idle, idleSoon); //hardcoded Qt::UserRole + 1, sue me.
16+
DECLARE_ENUM(enginesListRoles, channel = 257, module, engineState, analysisStatus, runsWhat, running, idle, idleSoon); //hardcoded Qt::UserRole + 1
1717

1818
struct unexpectedEngineReply : public std::runtime_error
1919
{

Common/tempfiles.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ void TempFiles::deleteStrayRootFiles(const stringvec& validIDs, long outOfDateDe
362362
{
363363
std::filesystem::path p = itr->path();
364364

365-
Log::log() << "looking at file " << p.string() << std::endl;
365+
//Log::log() << "looking at file " << p.string() << std::endl;
366366

367367
string fileName = Utils::osPath(p.filename());
368368
bool is_directory = std::filesystem::is_directory(p, error);

CommonData/CMakeLists.txt

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,18 @@ target_include_directories(
4141
${R_INCLUDE_PATH}
4242
${R_HOME_PATH}/include
4343
${RCPP_PATH}/include
44-
${Boost_INCLUDE_DIRS}
44+
${Boost_INCLUDE_DIRS}
4545
PRIVATE
4646
SQLite::SQLite3
4747
)
4848

4949
target_link_libraries(
5050
CommonData
5151
PUBLIC
52+
Qt::Core
53+
Qt::Gui
54+
Qt::Qml
55+
Qt::Quick
5256
LibArchive::LibArchive
5357
# Common
5458
SQLite::SQLite3
@@ -59,10 +63,13 @@ target_link_libraries(
5963

6064
target_compile_definitions(
6165
CommonData
62-
PUBLIC $<$<BOOL:${JASP_PRINT_ENGINE_MESSAGES}>:PRINT_ENGINE_MESSAGES>
63-
BUILDING_JASP_ENGINE R_HOME=${R_HOME_PATH}
64-
$<$<BOOL:${JASP_TIMER_USED}>:PROFILE_JASP>
65-
JSONCPP_NO_LOCALE_SUPPORT )
66+
PUBLIC
67+
$<$<BOOL:${JASP_PRINT_ENGINE_MESSAGES}>:PRINT_ENGINE_MESSAGES>
68+
BUILDING_JASP_ENGINE R_HOME=${R_HOME_PATH}
69+
$<$<BOOL:${JASP_TIMER_USED}>:PROFILE_JASP>
70+
JSONCPP_NO_LOCALE_SUPPORT
71+
JASP_USES_QT_HERE
72+
)
6673

6774
if(APPLE OR WINDOWS)
6875
target_compile_definitions(CommonData PUBLIC BOOST_INTERPROCESS_SHARED_DIR_FUNC)

0 commit comments

Comments
 (0)