make editable

JorisGoosen · JorisGoosen · commit d2ce491fd606 · 2025-09-02T12:45:42.000+02:00
diff --git a/CommonData/dataset.cpp b/CommonData/dataset.cpp
@@ -1038,7 +1038,7 @@ QVariant DataSet::headerData(int section, Qt::Orientation orientation, int role)
 
 Qt::ItemFlags DataSet::flags(const QModelIndex &index) const
 {
-	bool	isEditable	= dataMode() && index.column() >= 0 && index.column() < columnCount() && columns()[index.column()]->isComputed();
+	bool	isEditable	= dataMode() && index.column() >= 0 && index.column() < columnCount() && !columns()[index.column()]->isComputed();
 
 	return Qt::ItemIsSelectable | Qt::ItemIsEnabled | (isEditable ? Qt::ItemIsEditable : Qt::NoItemFlags);
 }
diff --git a/Desktop/components/JASP/Widgets/DataTableViewEdit.qml b/Desktop/components/JASP/Widgets/DataTableViewEdit.qml
@@ -4,9 +4,8 @@ import JASP.Controls		as JaspControls
 import QtQml.Models
 
 
-Rectangle
+Item
 {
-	color: "purple"
 	id:							editItemRoot
 	z:							10
 	onVisibleChanged:			{ isEditing = false; keyPressed = false }

Original file line number	Diff line number	Diff line change
`@@ -1038,7 +1038,7 @@ QVariant DataSet::headerData(int section, Qt::Orientation orientation, int role)`
`1038`	`1038`
`1039`	`1039`	`Qt::ItemFlags DataSet::flags(const QModelIndex &index) const`
`1040`	`1040`	`{`
`1041`		`- bool isEditable = dataMode() && index.column() >= 0 && index.column() < columnCount() && columns()[index.column()]->isComputed();`
	`1041`	`+ bool isEditable = dataMode() && index.column() >= 0 && index.column() < columnCount() && !columns()[index.column()]->isComputed();`
`1042`	`1042`
`1043`	`1043`	`return Qt::ItemIsSelectable \| Qt::ItemIsEnabled \| (isEditable ? Qt::ItemIsEditable : Qt::NoItemFlags);`
`1044`	`1044`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,9 +4,8 @@ import JASP.Controls as JaspControls`
`4`	`4`	`import QtQml.Models`
`5`	`5`
`6`	`6`
`7`		`-Rectangle`
	`7`	`+Item`
`8`	`8`	`{`
`9`		`- color: "purple"`
`10`	`9`	`id: editItemRoot`
`11`	`10`	`z: 10`
`12`	`11`	`onVisibleChanged: { isEditing = false; keyPressed = false }`