- Fixed a build problem related to the use of -Wstrict-prototypes with Clang.

- Disabled the conformance tests for ARM-based runners in the GitHub Actions
  CI workflow since these tests take too long.
- Changed the GitHub Actions CI release workflow to use the ubuntu-24.04
  runner.

Author: mdadams

.github/workflows/release.yml

@@ -13,7 +13,7 @@ on:
 jobs:
   build:
     #runs-on: ubuntu-latest
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       ############################################################
       - name: Checkout

CMakeLists.txt

@@ -314,6 +314,7 @@ message("CMAKE_LINKER: ${CMAKE_LINKER}")
 
 # Customize the compiler flags for warning messages.
 if(CMAKE_C_COMPILER_ID STREQUAL "Clang" OR CMAKE_C_COMPILER_ID STREQUAL "GNU")
+
 	check_c_compiler_flag("-Wno-stringop-truncation"
 	  JAS_GCC_WARN_NO_STRINGOP_TRUNCATION)
 	check_c_compiler_flag("-Wno-stringop-overflow"
@@ -331,7 +332,16 @@ if(CMAKE_C_COMPILER_ID STREQUAL "Clang" OR CMAKE_C_COMPILER_ID STREQUAL "GNU")
 	add_c_compile_options(-Wno-sign-compare)
 	add_c_compile_options(-Wformat)
 	add_c_compile_options(-Wmissing-prototypes)
-	add_c_compile_options(-Wstrict-prototypes)
+
+	# NOTE: The semantics of -Wstrict-prototypes differs in GCC and Clang.
+	# GCC does not warn about empty parameter lists in function definitions,
+	# while Clang does warn about this.
+	if(CMAKE_C_COMPILER_ID STREQUAL "GNU")
+		add_c_compile_options(-Wstrict-prototypes)
+	elseif(CMAKE_C_COMPILER_ID STREQUAL "Clang")
+		add_c_compile_options(-Wno-strict-prototypes)
+	endif()
+
 	add_c_compile_options(-Wno-type-limits)
 	if (JAS_CLANG_WARN_NO_OUT_OF_RANGE_COMPARE)
 		add_c_compile_options(-Wno-tautological-constant-out-of-range-compare)
@@ -357,7 +367,9 @@ if(CMAKE_C_COMPILER_ID STREQUAL "Clang" OR CMAKE_C_COMPILER_ID STREQUAL "GNU")
 		#add_c_compile_options(-Werror)
 		set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")
 	endif()
+
 elseif(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
+
 	# possibly lossy conversion
 	add_c_compile_options(/wd4244)
 	# different const qualifiers
@@ -372,6 +384,7 @@ elseif(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
 		# Treat all compiler warnings as errors.
 		add_c_compile_options(/WX)
 	endif()
+
 endif()
 
 if(JAS_ENABLE_HIDDEN)

build/build_all

@@ -233,10 +233,11 @@ debug_level=0
 strict=1
 command_file=
 enable_test=1
+enable_conformance_test=1
 requested_tests=()
 hard_fail=0
 
-while getopts hvb:cnd:swC:Xqt:F option; do
+while getopts hvb:cnd:swC:XYqt:F option; do
 	case "$option" in
 	n)
 		enable=0;;
@@ -265,6 +266,8 @@ while getopts hvb:cnd:swC:Xqt:F option; do
 		strict=1;;
 	X)
 		enable_test=0;;
+	Y)
+		enable_conformance_test=0;;
 	h)
 		usage;;
 	*)
@@ -298,6 +301,13 @@ $sysinfo_data
 ================================================================================
 EOF
 
+if [ -n "$RUNNER_OS" ]; then
+	echo "RUNNER_NAME: $RUNNER_NAME"
+	echo "RUNNER_OS: $RUNNER_OS"
+	echo "RUNNER_ACTION: $RUNNER_ACTION"
+fi
+
+
 os=unknown
 if [ -n "$RUNNER_OS" ]; then
 	case "$RUNNER_OS" in
@@ -322,6 +332,15 @@ if [ -n "$RUNNER_OS" ]; then
 			;;
 		esac
 	fi
+
+	# Disable conformance tests for ARM since these tests take too long.
+	# Do similarly for Windows.
+	case "$RUNNER_NAME" in
+	ubuntu-*-arm|windows-*)
+		echo "WARNING: disabling conformance tests"
+		enable_conformance_test=0
+		;;
+	esac
 fi
 #ubuntu_clang_hack=0
 
@@ -366,16 +385,14 @@ esac
 
 if [ "$enable_test" -ne 0 ]; then
 	test_option=(--test)
-	conformance_tests_option=(--conformance-tests)
 else
 	test_option=(--no-test)
-	conformance_tests_option=(--no-conformance-tests)
 fi
-case "$os" in
-windows)
+if [ "$enable_conformance_test" -ne 0 ]; then
+	conformance_tests_option=(--conformance-tests)
+else
 	conformance_tests_option=(--no-conformance-tests)
-	;;
-esac
+fi
 
 ################################################################################