Skip to content

Commit 4abe94e

Browse files
authored
test(go): enable cross-catalog/schema ingest tests (adbc-drivers#97)
Closes adbc-drivers#96.
1 parent b58245c commit 4abe94e

File tree

5 files changed

+23
-2
lines changed

5 files changed

+23
-2
lines changed

.github/workflows/generate.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ additional-make-args = ["BUILD_TAGS=minicore_disabled"]
2323
SNOWFLAKE_DATABASE = { secret = "SNOWFLAKE_DATABASE", contexts = ["validate"] }
2424
SNOWFLAKE_SCHEMA = { secret = "SNOWFLAKE_SCHEMA", contexts = ["validate"] }
2525
SNOWFLAKE_URI = { secret = "SNOWFLAKE_URI", contexts = ["validate"] }
26+
SNOWFLAKE_SCHEMA_SECONDARY = { secret = "SNOWFLAKE_SCHEMA_SECONDARY", contexts = ["validate"] }
27+
SNOWFLAKE_DATABASE_SECONDARY = { secret = "SNOWFLAKE_DATABASE_SECONDARY", contexts = ["validate"] }
28+
SNOWFLAKE_DATABASE_SECONDARY_SCHEMA = { secret = "SNOWFLAKE_DATABASE_SECONDARY_SCHEMA", contexts = ["validate"] }
2629

2730
[validation]
2831
[validation.extra-dependencies]

.github/workflows/go_release.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,9 @@ jobs:
226226
SNOWFLAKE_DATABASE: ${{ secrets.SNOWFLAKE_DATABASE }}
227227
SNOWFLAKE_SCHEMA: ${{ secrets.SNOWFLAKE_SCHEMA }}
228228
SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}
229+
SNOWFLAKE_SCHEMA_SECONDARY: ${{ secrets.SNOWFLAKE_SCHEMA_SECONDARY }}
230+
SNOWFLAKE_DATABASE_SECONDARY: ${{ secrets.SNOWFLAKE_DATABASE_SECONDARY }}
231+
SNOWFLAKE_DATABASE_SECONDARY_SCHEMA: ${{ secrets.SNOWFLAKE_DATABASE_SECONDARY_SCHEMA }}
229232
working-directory: go
230233
run: |
231234
set -a

.github/workflows/go_test.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ on:
5555
required: true
5656
SNOWFLAKE_URI:
5757
required: true
58+
SNOWFLAKE_SCHEMA_SECONDARY:
59+
required: true
60+
SNOWFLAKE_DATABASE_SECONDARY:
61+
required: true
62+
SNOWFLAKE_DATABASE_SECONDARY_SCHEMA:
63+
required: true
5864

5965
concurrency:
6066
# Must share concurrency group with release workflow since it also builds/tests
@@ -273,6 +279,9 @@ jobs:
273279
SNOWFLAKE_DATABASE: ${{ secrets.SNOWFLAKE_DATABASE }}
274280
SNOWFLAKE_SCHEMA: ${{ secrets.SNOWFLAKE_SCHEMA }}
275281
SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}
282+
SNOWFLAKE_SCHEMA_SECONDARY: ${{ secrets.SNOWFLAKE_SCHEMA_SECONDARY }}
283+
SNOWFLAKE_DATABASE_SECONDARY: ${{ secrets.SNOWFLAKE_DATABASE_SECONDARY }}
284+
SNOWFLAKE_DATABASE_SECONDARY_SCHEMA: ${{ secrets.SNOWFLAKE_DATABASE_SECONDARY_SCHEMA }}
276285
working-directory: go
277286
run: |
278287
set -a

.github/workflows/go_test_pr.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ jobs:
7575
SNOWFLAKE_DATABASE: ${{ secrets.SNOWFLAKE_DATABASE }}
7676
SNOWFLAKE_SCHEMA: ${{ secrets.SNOWFLAKE_SCHEMA }}
7777
SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}
78+
SNOWFLAKE_SCHEMA_SECONDARY: ${{ secrets.SNOWFLAKE_SCHEMA_SECONDARY }}
79+
SNOWFLAKE_DATABASE_SECONDARY: ${{ secrets.SNOWFLAKE_DATABASE_SECONDARY }}
80+
SNOWFLAKE_DATABASE_SECONDARY_SCHEMA: ${{ secrets.SNOWFLAKE_DATABASE_SECONDARY_SCHEMA }}
7881

7982
report:
8083
name: comment on PR

go/validation/tests/snowflake.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ class SnowflakeQuirks(model.DriverQuirks):
3535
get_objects_constraints_unique=False,
3636
statement_bind=True,
3737
statement_bulk_ingest=True,
38-
statement_bulk_ingest_catalog=False,
39-
statement_bulk_ingest_schema=False,
38+
statement_bulk_ingest_catalog=True,
39+
statement_bulk_ingest_schema=True,
4040
statement_bulk_ingest_temporary=False,
4141
statement_execute_schema=True,
4242
statement_get_parameter_schema=False,
@@ -45,6 +45,9 @@ class SnowflakeQuirks(model.DriverQuirks):
4545
statement_rows_affected_ddl=False,
4646
current_catalog=model.FromEnv("SNOWFLAKE_DATABASE"),
4747
current_schema=model.FromEnv("SNOWFLAKE_SCHEMA"),
48+
secondary_schema=model.FromEnv("SNOWFLAKE_SCHEMA_SECONDARY"),
49+
secondary_catalog=model.FromEnv("SNOWFLAKE_DATABASE_SECONDARY"),
50+
secondary_catalog_schema=model.FromEnv("SNOWFLAKE_DATABASE_SECONDARY_SCHEMA"),
4851
supported_xdbc_fields=[],
4952
)
5053
setup = model.DriverSetup(

0 commit comments

Comments
 (0)