Skip to content

Commit 76dc769

Browse files
author
emmanue1
committed
Fix bug on key listener of "Search In Constant" dialog
1 parent 3ebe6ea commit 76dc769

File tree

2 files changed

+33
-35
lines changed

2 files changed

+33
-35
lines changed

app/src/main/java/org/jd/gui/view/SearchInConstantPoolsView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public SearchInConstantPoolsView(
103103
}
104104
}
105105
@Override public void keyPressed(KeyEvent e) {
106-
if (e.getKeyChar() == KeyEvent.VK_DOWN) {
106+
if (e.getKeyCode() == KeyEvent.VK_DOWN) {
107107
DefaultMutableTreeNode root = (DefaultMutableTreeNode)searchInConstantPoolsTree.getModel().getRoot();
108108
if (root.getChildCount() > 0) {
109109
searchInConstantPoolsTree.requestFocus();
@@ -194,7 +194,7 @@ public SearchInConstantPoolsView(
194194
searchInConstantPoolsTree.setCellRenderer(new TreeNodeRenderer());
195195
searchInConstantPoolsTree.addKeyListener(new KeyAdapter() {
196196
@Override public void keyPressed(KeyEvent e) {
197-
if (e.getKeyChar() == KeyEvent.VK_UP) {
197+
if (e.getKeyCode() == KeyEvent.VK_UP) {
198198
if (searchInConstantPoolsTree.getLeadSelectionRow() == 0) {
199199
searchInConstantPoolsEnterTextField.requestFocus();
200200
e.consume();

services/src/main/java/org/jd/gui/view/component/AbstractTextPage.java

Lines changed: 31 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -91,41 +91,39 @@ public void mouseClicked(MouseEvent e) {
9191
scrollPane.removeMouseWheelListener(listener);
9292
}
9393

94-
scrollPane.addMouseWheelListener(new MouseWheelListener() {
95-
public void mouseWheelMoved(MouseWheelEvent event) {
96-
if ((event.getModifiers() & (Event.META_MASK|Event.CTRL_MASK)) != 0) {
97-
int x = event.getX() + scrollPane.getX() - textArea.getX();
98-
int y = event.getY() + scrollPane.getY() - textArea.getY();
99-
int offset = textArea.viewToModel(new Point(x, y));
100-
101-
// Update font size
102-
if (event.getWheelRotation() > 0) {
103-
INCREASE_FONT_SIZE_ACTION.actionPerformedImpl(null, textArea);
104-
} else {
105-
DECREASE_FONT_SIZE_ACTION.actionPerformedImpl(null, textArea);
106-
}
107-
108-
// Save preferences
109-
if (preferences != null) {
110-
preferences.put(FONT_SIZE_KEY, String.valueOf(textArea.getFont().getSize()));
111-
}
94+
scrollPane.addMouseWheelListener(e -> {
95+
if ((e.getModifiers() & (Event.META_MASK|Event.CTRL_MASK)) != 0) {
96+
int x = e.getX() + scrollPane.getX() - textArea.getX();
97+
int y = e.getY() + scrollPane.getY() - textArea.getY();
98+
int offset = textArea.viewToModel(new Point(x, y));
99+
100+
// Update font size
101+
if (e.getWheelRotation() > 0) {
102+
INCREASE_FONT_SIZE_ACTION.actionPerformedImpl(null, textArea);
103+
} else {
104+
DECREASE_FONT_SIZE_ACTION.actionPerformedImpl(null, textArea);
105+
}
112106

113-
try {
114-
Rectangle newRectangle = textArea.modelToView(offset);
115-
int newY = newRectangle.y + (newRectangle.height >> 1);
107+
// Save preferences
108+
if (preferences != null) {
109+
preferences.put(FONT_SIZE_KEY, String.valueOf(textArea.getFont().getSize()));
110+
}
116111

117-
// Scroll
118-
Point viewPosition = scrollPane.getViewport().getViewPosition();
119-
viewPosition.y = Math.max(viewPosition.y +newY - y, 0);
120-
scrollPane.getViewport().setViewPosition(viewPosition);
121-
} catch (BadLocationException e) {
122-
assert ExceptionUtil.printStackTrace(e);
123-
}
124-
} else {
125-
// Call default listeners
126-
for (MouseWheelListener listener : mouseWheelListeners) {
127-
listener.mouseWheelMoved(event);
128-
}
112+
try {
113+
Rectangle newRectangle = textArea.modelToView(offset);
114+
int newY = newRectangle.y + (newRectangle.height >> 1);
115+
116+
// Scroll
117+
Point viewPosition = scrollPane.getViewport().getViewPosition();
118+
viewPosition.y = Math.max(viewPosition.y +newY - y, 0);
119+
scrollPane.getViewport().setViewPosition(viewPosition);
120+
} catch (BadLocationException ee) {
121+
assert ExceptionUtil.printStackTrace(ee);
122+
}
123+
} else {
124+
// Call default listeners
125+
for (MouseWheelListener listener : mouseWheelListeners) {
126+
listener.mouseWheelMoved(e);
129127
}
130128
}
131129
});

0 commit comments

Comments
 (0)