Fixed sonar

Author: javadev

src/main/java/g3501_3600/s3552_grid_teleportation_traversal/Solution.java

@@ -1,6 +1,6 @@
 package g3501_3600.s3552_grid_teleportation_traversal;
 
-// #Medium #2025_05_18_Time_133_ms_(99.44%)_Space_60.94_MB_(99.44%)
+// #Medium #2025_05_18_Time_139_ms_(99.44%)_Space_61.40_MB_(98.89%)
 
 import java.util.ArrayList;
 import java.util.LinkedList;
@@ -11,14 +11,7 @@
 public class Solution {
     private static final int[][] ADJACENT = new int[][] {{0, 1}, {1, 0}, {-1, 0}, {0, -1}};
 
-    public int minMoves(String[] matrix) {
-        int m = matrix.length;
-        int n = matrix[0].length();
-        if ((m == 1 && n == 1)
-                || (matrix[0].charAt(0) != '.'
-                        && matrix[m - 1].charAt(n - 1) == matrix[0].charAt(0))) {
-            return 0;
-        }
+    private List<int[]>[] initializePortals(int m, int n, String[] matrix) {
         List<int[]>[] portalsToPositions = new ArrayList[26];
         for (int i = 0; i < 26; i++) {
             portalsToPositions[i] = new ArrayList<>();
@@ -31,8 +24,14 @@ public int minMoves(String[] matrix) {
                 }
             }
         }
-        boolean[][] visited = new boolean[m][n];
-        Queue<int[]> queue = new LinkedList<>();
+        return portalsToPositions;
+    }
+
+    private void initializeQueue(
+            Queue<int[]> queue,
+            boolean[][] visited,
+            String[] matrix,
+            List<int[]>[] portalsToPositions) {
         if (matrix[0].charAt(0) != '.') {
             int idx = matrix[0].charAt(0) - 'A';
             for (int[] pos : portalsToPositions[idx]) {
@@ -43,6 +42,46 @@ public int minMoves(String[] matrix) {
             queue.offer(new int[] {0, 0});
         }
         visited[0][0] = true;
+    }
+
+    private boolean isValidMove(int r, int c, int m, int n, boolean[][] visited, String[] matrix) {
+        return !(r < 0 || r == m || c < 0 || c == n || visited[r][c] || matrix[r].charAt(c) == '#');
+    }
+
+    private boolean processPortal(
+            int r,
+            int c,
+            int m,
+            int n,
+            Queue<int[]> queue,
+            boolean[][] visited,
+            String[] matrix,
+            List<int[]>[] portalsToPositions) {
+        int idx = matrix[r].charAt(c) - 'A';
+        for (int[] pos : portalsToPositions[idx]) {
+            if (pos[0] == m - 1 && pos[1] == n - 1) {
+                return true;
+            }
+            queue.offer(pos);
+            visited[pos[0]][pos[1]] = true;
+        }
+        return false;
+    }
+
+    public int minMoves(String[] matrix) {
+        int m = matrix.length;
+        int n = matrix[0].length();
+        if ((m == 1 && n == 1)
+                || (matrix[0].charAt(0) != '.'
+                        && matrix[m - 1].charAt(n - 1) == matrix[0].charAt(0))) {
+            return 0;
+        }
+
+        List<int[]>[] portalsToPositions = initializePortals(m, n, matrix);
+        boolean[][] visited = new boolean[m][n];
+        Queue<int[]> queue = new LinkedList<>();
+        initializeQueue(queue, visited, matrix, portalsToPositions);
+
         int moves = 0;
         while (!queue.isEmpty()) {
             int sz = queue.size();
@@ -51,22 +90,12 @@ public int minMoves(String[] matrix) {
                 for (int[] adj : ADJACENT) {
                     int r = adj[0] + curr[0];
                     int c = adj[1] + curr[1];
-                    if (r < 0
-                            || r == m
-                            || c < 0
-                            || c == n
-                            || visited[r][c]
-                            || matrix[r].charAt(c) == '#') {
+                    if (!isValidMove(r, c, m, n, visited, matrix)) {
                         continue;
                     }
                     if (matrix[r].charAt(c) != '.') {
-                        int idx = matrix[r].charAt(c) - 'A';
-                        for (int[] pos : portalsToPositions[idx]) {
-                            if (pos[0] == m - 1 && pos[1] == n - 1) {
-                                return moves + 1;
-                            }
-                            queue.offer(pos);
-                            visited[pos[0]][pos[1]] = true;
+                        if (processPortal(r, c, m, n, queue, visited, matrix, portalsToPositions)) {
+                            return moves + 1;
                         }
                     } else {
                         if (r == m - 1 && c == n - 1) {

src/main/java/g3501_3600/s3553_minimum_weighted_subgraph_with_the_required_paths_ii/Solution.java

@@ -8,7 +8,6 @@
 
 @SuppressWarnings("unchecked")
 public class Solution {
-    private int p;
     private List<int[]>[] graph;
     private int[] euler;
     private int[] depth;
@@ -18,7 +17,7 @@ public class Solution {
     private long[] dists;
 
     public int[] minimumWeight(int[][] edges, int[][] queries) {
-        p = 0;
+        int p = 0;
         for (int[] e : edges) {
             p = Math.max(p, Math.max(e[0], e[1]));
         }