Skip to content

Commit 5873322

Browse files
committed
Add check for custom Number in U.subtract(values).
1 parent 7b0c348 commit 5873322

File tree

2 files changed

+3
-1
lines changed
  • src
    • main/java/com/github/underscore/lodash
    • test/java/com/github/underscore/lodash

2 files changed

+3
-1
lines changed

src/main/java/com/github/underscore/lodash/U.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,8 @@ public static <T extends Number> T subtract(final T ... values) {
11361136
result = add(result, (T) Long.valueOf(values[i].longValue() * -1));
11371137
} else if (result instanceof Short) {
11381138
result = add(result, (T) Short.valueOf((short) (values[i].shortValue() * -1)));
1139+
} else {
1140+
throw new UnsupportedOperationException("Subtract only supports official subclasses of Number");
11391141
}
11401142
}
11411143
return result;

src/test/java/com/github/underscore/lodash/MathTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ public void subtract() {
276276
assertEquals(null, U.subtract());
277277
}
278278

279-
@Test
279+
@Test(expected = UnsupportedOperationException.class)
280280
public void subtractError() {
281281
class MyNumber extends Number {
282282
public int intValue() {

0 commit comments

Comments
 (0)