Skip to content

Commit 5eeb9f1

Browse files
committed
Fix slice method for index 0.
1 parent 1233662 commit 5eeb9f1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/main/java/com/github/underscore/$.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1778,7 +1778,7 @@ public List<T> concatWith(final Iterable<T> ... other) {
17781778

17791779
public static <T> List<T> slice(final Iterable<T> iterable, final int start) {
17801780
final List<T> result;
1781-
if (start > 0) {
1781+
if (start >= 0) {
17821782
result = newArrayList(iterable).subList(start, size(iterable));
17831783
} else {
17841784
result = newArrayList(iterable).subList(size(iterable) + start, size(iterable));
@@ -1796,7 +1796,7 @@ public List<T> slice(final int start) {
17961796

17971797
public static <T> List<T> slice(final Iterable<T> iterable, final int start, final int end) {
17981798
final List<T> result;
1799-
if (start > 0) {
1799+
if (start >= 0) {
18001800
if (end > 0) {
18011801
result = newArrayList(iterable).subList(start, end);
18021802
} else {

src/test/java/com/github/underscore/UnderscoreTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ public void slice() {
107107
assertEquals(asList(3, 4, 5), $.slice(asList(1, 2, 3, 4, 5), 2));
108108
assertEquals(asList(3, 4, 5), new $(asList(1, 2, 3, 4, 5)).slice(2));
109109
assertEquals(asList(2, 3, 4), $.slice(asList(1, 2, 3, 4, 5), 1, 4));
110+
assertEquals(asList("a", "b"), $.slice(asList("a", "b", "c", "d"), 0, 2));
110111
assertEquals(asList(2, 3, 4), $.slice(asList(1, 2, 3, 4, 5), 1, -1));
111112
assertEquals(asList(3), $.slice(asList(1, 2, 3, 4, 5), 2, 3));
112113
assertEquals(asList(3), new $(asList(1, 2, 3, 4, 5)).slice(2, 3));

0 commit comments

Comments
 (0)