Fix idea warnings.

Author: javadev

src/main/java/com/github/underscore/lodash/Base32.java

@@ -30,15 +30,15 @@
 public final class Base32 {
 
     private static final Charset UTF_8 = Charset.forName("UTF-8");
-    private static final Base32 INSTANCE = new Base32("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdef");
+    private static final Base32 INSTANCE = new Base32();
 
     private final char[] digits;
     private final int mask;
     private final int shift;
     private final Map<Character, Integer> charMap;
 
-    private Base32(final String alphabet) {
-        digits = alphabet.toCharArray();
+    private Base32() {
+        digits = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdef".toCharArray();
         mask = digits.length - 1;
         shift = Integer.numberOfTrailingZeros(digits.length);
         charMap = new HashMap<Character, Integer>();

src/main/java/com/github/underscore/lodash/U.java

@@ -2117,15 +2117,15 @@ public static String formatXml(String xml) {
     @SuppressWarnings("unchecked")
     public static Map<String, Object> removeMinusesAndConvertNumbers(Map<String, Object> map) {
         Map<String, Object> outMap = newLinkedHashMap();
-        for (String key : map.keySet()) {
+        for (Map.Entry<String, Object> entry : map.entrySet()) {
             final String newKey;
-            if (key.startsWith("-")) {
-                newKey = key.substring(1);
+            if (entry.getKey().startsWith("-")) {
+                newKey = entry.getKey().substring(1);
             } else {
-                newKey = key;
+                newKey = entry.getKey();
             }
-            if (!key.equals("-self-closing") && !key.equals("#omit-xml-declaration")) {
-                outMap.put(newKey, makeObject(map.get(key)));
+            if (!entry.getKey().equals("-self-closing") && !entry.getKey().equals("#omit-xml-declaration")) {
+                outMap.put(newKey, makeObject(entry.getValue()));
             }
         }
         return outMap;

src/test/java/com/github/underscore/FunctionsTest.java

@@ -112,7 +112,7 @@ public Integer apply(final Integer n) {
 */
 
     @Test
-    public void throttle() throws Exception {
+    public void throttle() {
         final Integer[] counter = new Integer[] {0};
         Supplier<Void> incr = new Supplier<Void>() { public Void get() {
             counter[0]++; return null; } };
@@ -127,7 +127,7 @@ public Void get() {
             }
         }, 60);
         await().atMost(180, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 throttleIncr.get();
                 return true;
             }
@@ -144,7 +144,7 @@ public Boolean call() throws Exception {
 */
 
     @Test
-    public void debounce() throws Exception {
+    public void debounce() {
         final Integer[] counter = new Integer[] {0};
         Supplier<Void> incr = new Supplier<Void>() { public Void get() {
             counter[0]++; return null; } };
@@ -159,7 +159,7 @@ public Void get() {
             }
         }, 60);
         await().atMost(120, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 return true;
             }
         });
@@ -170,7 +170,7 @@ public Boolean call() throws Exception {
 // Returns from the function before the alert runs.
 */
     @Test
-    public void defer() throws Exception {
+    public void defer() {
         final Integer[] counter = new Integer[] {0};
         U.defer(new Supplier<Void>() { public Void get() {
             try {
@@ -181,7 +181,7 @@ public void defer() throws Exception {
             counter[0]++; return null; } });
         assertEquals("incr was debounced", 0, counter[0].intValue());
         await().atLeast(60, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 assertEquals("incr was debounced", 1, counter[0].intValue());
                 return true;
             }
@@ -195,15 +195,15 @@ public Boolean call() throws Exception {
 // Application is only created once.
 */
     @Test
-    public void once() throws Exception {
+    public void once() {
         final Integer[] counter = new Integer[] {0};
         Supplier<Integer> incr = new Supplier<Integer>() { public Integer get() {
             counter[0]++; return counter[0]; } };
         final Supplier<Integer> onceIncr = U.once(incr);
         onceIncr.get();
         onceIncr.get();
         await().atLeast(60, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 assertEquals("incr was called only once", 1, counter[0].intValue());
                 assertEquals("stores a memo to the last value", 1, onceIncr.get().intValue());
                 return true;
@@ -344,37 +344,37 @@ public void iteratee() {
     }
 
     @Test
-    public void setTimeout() throws Exception {
+    public void setTimeout() {
         final Integer[] counter = new Integer[] {0};
         Supplier<Void> incr = new Supplier<Void>() { public Void get() {
             counter[0]++; return null; } };
         U.setTimeout(incr, 0);
         await().atLeast(40, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 assertEquals(1, counter[0].intValue());
                 return true;
             }
         });
     }
 
     @Test
-    public void clearTimeout() throws Exception {
+    public void clearTimeout() {
         final Integer[] counter = new Integer[] {0};
         Supplier<Void> incr = new Supplier<Void>() { public Void get() {
             counter[0]++; return null; } };
         java.util.concurrent.ScheduledFuture future = U.setTimeout(incr, 20);
         U.clearTimeout(future);
         U.clearTimeout(null);
         await().atLeast(40, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 assertEquals(0, counter[0].intValue());
                 return true;
             }
         });
     }
 
     @Test
-    public void setInterval() throws Exception {
+    public void setInterval() {
         final Integer[] counter = new Integer[] {0};
         Supplier<Void> incr = new Supplier<Void>() { public Void get() {
             if (counter[0] < 4) {
@@ -383,7 +383,7 @@ public void setInterval() throws Exception {
             return null; } };
         U.setInterval(incr, 10);
         await().atLeast(45, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 assertTrue("Counter is not in range [0, 4] " + counter[0],
                     asList(0, 4).contains(counter[0]));
                 return true;
@@ -392,15 +392,15 @@ public Boolean call() throws Exception {
     }
 
     @Test
-    public void clearInterval() throws Exception {
+    public void clearInterval() {
         final Integer[] counter = new Integer[] {0};
         Supplier<Void> incr = new Supplier<Void>() { public Void get() {
             counter[0]++; return null; } };
         java.util.concurrent.ScheduledFuture future = U.setInterval(incr, 20);
         U.clearInterval(future);
         U.clearInterval(null);
         await().atLeast(40, TimeUnit.MILLISECONDS).until(new Callable<Boolean>() {
-            public Boolean call() throws Exception {
+            public Boolean call() {
                 assertEquals(0, counter[0].intValue());
                 return true;
             }

src/test/java/com/github/underscore/lodash/StringTest.java

@@ -3656,7 +3656,7 @@ public void toJsonJavaString() {
     }
 
     @Test
-    public void main() throws Exception {
+    public void main() {
         U.main(new String[] {});
         new U<String>(new ArrayList<String>());
         new U<String>("");