Skip to content

Commit ff341ed

Browse files
authored
Fixed sonar warnings.
1 parent 2fbc151 commit ff341ed

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

src/main/java/com/github/underscore/U.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2760,7 +2760,11 @@ public static Map<String, Object> replaceSelfClosingWithNull(Map<String, Object>
27602760

27612761
@SuppressWarnings("unchecked")
27622762
public static Map<String, Object> replaceSelfClosingWithEmpty(Map<String, Object> map) {
2763-
return (Map<String, Object>) replaceSelfClosingWithValue(map, "");
2763+
Object result = replaceSelfClosingWithValue(map, "");
2764+
if (result instanceof Map) {
2765+
return (Map<String, Object>) result;
2766+
}
2767+
return Collections.emptyMap();
27642768
}
27652769

27662770
@SuppressWarnings("unchecked")

src/main/java/com/github/underscore/Xml.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1929,8 +1929,9 @@ public static String changeXmlEncoding(
19291929
Object result = fromXml(xml, FromType.FOR_FORMAT);
19301930
if (result instanceof Map) {
19311931
((Map) result).put(ENCODING, encoding);
1932+
return toXml((Map) result, identStep, ROOT);
19321933
}
1933-
return toXml((Map) result, identStep, ROOT);
1934+
return xml;
19341935
}
19351936

19361937
public static String changeXmlEncoding(String xml, String encoding) {

src/test/java/com/github/underscore/LodashTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -778,6 +778,9 @@ void xmlToJson() {
778778
Map<String, Object> map = U.newLinkedHashMap();
779779
map.put("-self-closing", "false");
780780
U.replaceSelfClosingWithNull(map);
781+
Map<String, Object> mapEmpty = U.newLinkedHashMap();
782+
mapEmpty.put("-self-closing", "true");
783+
U.replaceSelfClosingWithEmpty(mapEmpty);
781784
Map<String, Object> map2 = U.newLinkedHashMap();
782785
List<Object> list = U.newArrayList();
783786
list.add(U.newArrayList());
@@ -1239,8 +1242,7 @@ void changeXmlEncoding() {
12391242
"<?xml version=\"1.0\" encoding=\"UTF-8\"?><a>Test</a>",
12401243
Xml.XmlStringBuilder.Step.COMPACT,
12411244
"windows-1251"));
1242-
assertEquals(
1243-
"<?xml version=\"1.0\" encoding=\"UTF-8\"?><root>null</root>",
1245+
assertNull(
12441246
U.changeXmlEncoding(null, Xml.XmlStringBuilder.Step.COMPACT, "windows-1251"));
12451247
}
12461248

0 commit comments

Comments
 (0)