Respecting @priority for custom ExceptionMappers.

Change-Id: I3ee1321b2077b34f0301d53ded04ff23625efba0

Author: pavelbucek

core-common/src/main/java/org/glassfish/jersey/internal/inject/Providers.java

@@ -308,7 +308,10 @@ public static <T> Iterable<T> getAllProviders(
      * @return set of all available service provider instances for the contract
      */
     public static <T> Collection<ServiceHolder<T>> getAllServiceHolders(InjectionManager injectionManager, Class<T> contract) {
-        List<ServiceHolder<T>> providers = getServiceHolders(injectionManager, contract, CustomAnnotationLiteral.INSTANCE);
+        List<ServiceHolder<T>> providers = getServiceHolders(injectionManager,
+                                                             contract,
+                                                             Comparator.comparingInt(Providers::getPriority),
+                                                             CustomAnnotationLiteral.INSTANCE);
         providers.addAll(getServiceHolders(injectionManager, contract));
 
         LinkedHashSet<ServiceHolder<T>> providersSet = new LinkedHashSet<>();

tests/e2e-server/src/test/java/org/glassfish/jersey/tests/e2e/server/ExceptionMapperPriorityTest.java

@@ -0,0 +1,121 @@
+/*
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+ *
+ * Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved.
+ *
+ * The contents of this file are subject to the terms of either the GNU
+ * General Public License Version 2 only ("GPL") or the Common Development
+ * and Distribution License("CDDL") (collectively, the "License").  You
+ * may not use this file except in compliance with the License.  You can
+ * obtain a copy of the License at
+ * http://glassfish.java.net/public/CDDL+GPL_1_1.html
+ * or packager/legal/LICENSE.txt.  See the License for the specific
+ * language governing permissions and limitations under the License.
+ *
+ * When distributing the software, include this License Header Notice in each
+ * file and include the License file at packager/legal/LICENSE.txt.
+ *
+ * GPL Classpath Exception:
+ * Oracle designates this particular file as subject to the "Classpath"
+ * exception as provided by Oracle in the GPL Version 2 section of the License
+ * file that accompanied this code.
+ *
+ * Modifications:
+ * If applicable, add the following below the License Header, with the fields
+ * enclosed by brackets [] replaced by your own identifying information:
+ * "Portions Copyright [year] [name of copyright owner]"
+ *
+ * Contributor(s):
+ * If you wish your version of this file to be governed by only the CDDL or
+ * only the GPL Version 2, indicate your decision by adding "[Contributor]
+ * elects to include this software in this distribution under the [CDDL or GPL
+ * Version 2] license."  If you don't indicate a single choice of license, a
+ * recipient has the option to distribute your version of this file under
+ * either the CDDL, the GPL Version 2 or to extend the choice of license to
+ * its licensees as provided above.  However, if you add GPL Version 2 code
+ * and therefore, elected the GPL Version 2 license, then the option applies
+ * only if the new code is made subject to such option by the copyright
+ * holder.
+ */
+
+package org.glassfish.jersey.tests.e2e.server;
+
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.core.Application;
+import javax.ws.rs.core.Response;
+import javax.ws.rs.ext.ExceptionMapper;
+import javax.ws.rs.ext.Provider;
+
+import javax.annotation.Priority;
+
+import org.glassfish.jersey.server.ResourceConfig;
+import org.glassfish.jersey.test.JerseyTest;
+
+import org.junit.Test;
+import static org.hamcrest.core.Is.is;
+import static org.junit.Assert.assertThat;
+
+/**
+ * @author Pavel Bucek (pavel.bucek at oracle.com)
+ */
+public class ExceptionMapperPriorityTest extends JerseyTest {
+
+    @Override
+    protected Application configure() {
+        return new ResourceConfig(ExceptionMapperPriorityResource.class,
+                                  MyFirstExceptionMapper.class,
+                                  MySecondExceptionMapper.class,
+                                  MyThirdExceptionMapper.class);
+    }
+
+    @Test
+    public void priorityTest() {
+        String response = target().request().get(String.class);
+
+        assertThat(response, is(MySecondExceptionMapper.class.getName()));
+    }
+
+    @Path("/")
+    public static class ExceptionMapperPriorityResource {
+
+        @GET
+        public String get() throws MyException {
+            throw new MyException();
+        }
+    }
+
+    public static class MyException extends Exception {
+
+    }
+
+    @Provider
+    @Priority(300)
+    public static class MyFirstExceptionMapper implements ExceptionMapper<MyException> {
+
+        @Override
+        public Response toResponse(MyException exception) {
+            return Response.ok(MyFirstExceptionMapper.class.getName()).build();
+        }
+    }
+
+    @Provider
+    @Priority(100)
+    public static class MySecondExceptionMapper implements ExceptionMapper<MyException> {
+
+        @Override
+        public Response toResponse(MyException exception) {
+            return Response.ok(MySecondExceptionMapper.class.getName()).build();
+        }
+    }
+
+    @Provider
+    @Priority(200)
+    public static class MyThirdExceptionMapper implements ExceptionMapper<MyException> {
+
+        @Override
+        public Response toResponse(MyException exception) {
+            return Response.ok(MyThirdExceptionMapper.class.getName()).build();
+        }
+    }
+}