Findbugs exclusion filter config update

Change-Id: I3aeb00cf17426a68332ad6e2221ee48e1f76ac1a

Author: Adam Lindenthal

core-common/src/main/java/org/glassfish/jersey/filter/LoggingFilter.java

@@ -295,7 +295,7 @@ public void aroundWriteTo(final WriterInterceptorContext writerInterceptorContex
         final LoggingStream stream = (LoggingStream) writerInterceptorContext.getProperty(ENTITY_LOGGER_PROPERTY);
         writerInterceptorContext.proceed();
         if (stream != null) {
-            log(stream.getStringBuilder());
+            log(stream.getStringBuilder(MessageUtils.getCharset(writerInterceptorContext.getMediaType())));
         }
     }
 
@@ -309,11 +309,11 @@ private class LoggingStream extends OutputStream {
             this.inner = inner;
         }
 
-        StringBuilder getStringBuilder() {
+        StringBuilder getStringBuilder(Charset charset) {
             // write entity to the builder
             final byte[] entity = baos.toByteArray();
 
-            b.append(new String(entity, 0, Math.min(entity.length, maxEntitySize)));
+            b.append(new String(entity, 0, Math.min(entity.length, maxEntitySize), charset));
             if (entity.length > maxEntitySize) {
                 b.append("...more...");
             }

etc/config/findbugs-exclude.xml

@@ -94,14 +94,45 @@
     <!-- individual ad-hoc ignores -->
     <!-- ServerScopeProvider.getFilteringScopes() - returned object would be identical -->
     <Match>
-        <Class name="~.*.ServerScopeProvider" />
-        <Method name="getFilteringScopes()" />
+        <Class name="org.glassfish.jersey.message.filtering.ServerScopeProvider" />
+        <Method name="getFilteringScopes" />
         <Bug pattern="RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED" />
     </Match>
 
+    <!-- used as fallback, can be ignored here -->
+    <Match>
+        <Bug pattern="DM_DEFAULT_ENCODING" />
+        <Class name="~.*.Base64" />
+    </Match>
+
     <!-- There are few cases in the codebase -->
     <Match>
         <Bug pattern="CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE" />
     </Match>
 
+    <Match>
+        <Bug pattern="REC_CATCH_EXCEPTION" />
+        <Class name="~.*.VfsSchemeResourceFinderFactory" />
+    </Match>
+
+    <!-- TODOs - those are the FindBugs warnings not resolved yet -->
+    <!-- Those exclusions should either be fixed or, after evaluation moved outside of this "TODO" section -->
+    <Match>
+        <Bug pattern="DM_DEFAULT_ENCODING" />
+        <Or>
+            <Class name="~.*.AbstractTemplateProcessor" />
+            <Class name="~.*.HmaSha1Method" />
+            <Class name="~.*.RsaSha1Method" />
+            <Class name="~.*.ConsumerCredentials" />
+            <Class name="~.*.AccessToken" />
+            <Class name="~.*.ClientIdentifier" />
+            <Class name="~.*.ChunkedInput" />
+            <Class name="~.*.ChunkedOutput" />
+        </Or>
+    </Match>
+
+    <Match>
+        <Class name="org.glassfish.jersey.apache.connector.ApacheConnector" />
+    </Match>
+
 </FindBugsFilter>