JERSEY-2781: Locale-dependent test fails in org.glassfish.jersey.message.internal.QualityTest.testEnhanceWithQualityParameter

 - Fixed string formatting in Quality.qualityValueToString
 - Updated test

Change-Id: I34b1f2491294db53c1213b6387d91c52592c9f97
Signed-off-by: Michal Gajdos <[email protected]>

Author: Michal Gajdos

core-common/src/main/java/org/glassfish/jersey/message/internal/Quality.java

@@ -42,6 +42,7 @@
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.HashMap;
+import java.util.Locale;
 import java.util.Map;
 
 /**
@@ -162,7 +163,7 @@ private static int compare(final int x, final int y) {
     }
 
     private static String qualityValueToString(final float quality) {
-        final StringBuilder qsb = new StringBuilder(String.format("%3.3f", (quality / 1000)));
+        final StringBuilder qsb = new StringBuilder(String.format(Locale.US, "%3.3f", (quality / 1000)));
 
         int lastIndex;
         while ((lastIndex = qsb.length() - 1) > 2 && qsb.charAt(lastIndex) == '0') {

core-common/src/test/java/org/glassfish/jersey/message/internal/QualityTest.java

@@ -39,11 +39,16 @@
  */
 package org.glassfish.jersey.message.internal;
 
+import java.util.Arrays;
+import java.util.Locale;
 import java.util.Map;
 
-import static org.glassfish.jersey.message.internal.MediaTypesTest.asMap;
-
+import org.junit.After;
+import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import static org.glassfish.jersey.message.internal.MediaTypesTest.asMap;
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.junit.Assert.assertThat;
 
@@ -52,8 +57,29 @@
  *
  * @author Marek Potociar (marek.potociar at oracle.com)
  */
+@RunWith(Parameterized.class)
 public class QualityTest {
 
+    private static final Locale ORIGINAL_LOCALE = Locale.getDefault();
+
+    @Parameterized.Parameters(name = "{0}")
+    public static Iterable<Object[]> data() {
+        return Arrays.asList(new Object[][]{{Locale.US}, {Locale.GERMANY}});
+    }
+
+    @Parameterized.Parameter(0)
+    public Locale locale;
+
+    @Before
+    public void setUp() throws Exception {
+        Locale.setDefault(locale);
+    }
+
+    @After
+    public void tearDown() throws Exception {
+        Locale.setDefault(ORIGINAL_LOCALE);
+    }
+
     /**
      * Test enhancing HTT header parameter map with a quality parameter.
      */
@@ -73,7 +99,6 @@ public void testEnhanceWithQualityParameter() {
         result = Quality.enhanceWithQualityParameter(null, "q", 222);
         assertThat(result, equalTo(asMap("q=0.222")));
 
-
         Map<String, String> parameters;
 
         parameters = asMap("a=b");