Skip to content
This repository was archived by the owner on May 28, 2018. It is now read-only.

Commit e21b718

Browse files
committed
JERSEY-2218: "Clear jdk6/jdk7 specific test cases"
Test can run on jdk6. Change-Id: I3dd08697efe7102f243d5073bf23dae40e1edc3b
1 parent 23e0023 commit e21b718

File tree

12 files changed

+17
-31
lines changed

12 files changed

+17
-31
lines changed

tests/integration/servlet-3-init-5/src/test/java/org/glassfish/jersey/tests/integration/servlet_3_init_5/HelloWorldResourceITCase.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141

4242
import org.glassfish.jersey.server.ResourceConfig;
4343
import org.glassfish.jersey.test.JerseyTest;
44+
import org.glassfish.jersey.test.TestProperties;
4445
import org.glassfish.jersey.test.external.ExternalTestContainerFactory;
4546
import org.glassfish.jersey.test.spi.TestContainerException;
4647
import org.glassfish.jersey.test.spi.TestContainerFactory;
@@ -56,6 +57,8 @@ public class HelloWorldResourceITCase extends JerseyTest {
5657

5758
@Override
5859
protected ResourceConfig configure() {
60+
enable(TestProperties.LOG_TRAFFIC);
61+
5962
return new ResourceConfig(HelloWorldResource.class);
6063
}
6164

tests/integration/servlet-3-init-provider/pom.xml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
<dependency>
6060
<groupId>org.glassfish.jersey.containers</groupId>
6161
<artifactId>jersey-container-servlet</artifactId>
62-
<scope>provided</scope>
6362
</dependency>
6463
<dependency>
6564
<groupId>org.glassfish.jersey.ext</groupId>
@@ -80,28 +79,20 @@
8079
</dependencies>
8180

8281
<build>
83-
<finalName>${project.artifactId}</finalName>
8482
<plugins>
8583
<plugin>
8684
<groupId>org.apache.maven.plugins</groupId>
8785
<artifactId>maven-compiler-plugin</artifactId>
8886
</plugin>
8987
<plugin>
90-
<artifactId>maven-surefire-plugin</artifactId>
91-
<configuration>
92-
<skipTests>${skipTests}</skipTests>
93-
<systemPropertyVariables>
94-
<jersey.config.test.container.factory>${testContainerFactory}</jersey.config.test.container.factory>
95-
<jersey.config.test.container.port>${testContainerPort}</jersey.config.test.container.port>
96-
</systemPropertyVariables>
97-
</configuration>
88+
<groupId>org.apache.maven.plugins</groupId>
89+
<artifactId>maven-failsafe-plugin</artifactId>
90+
</plugin>
91+
<plugin>
92+
<groupId>org.mortbay.jetty</groupId>
93+
<artifactId>jetty-maven-plugin</artifactId>
9894
</plugin>
9995
</plugins>
10096
</build>
10197

102-
<properties>
103-
<skipTests>true</skipTests>
104-
<testContainerFactory>org.glassfish.jersey.test.external.ExternalTestContainerFactory</testContainerFactory>
105-
<testContainerPort>8080</testContainerPort>
106-
</properties>
10798
</project>

tests/integration/servlet-3-init-provider/src/main/java/org/glassfish/jersey/tests/integration/servlet_3_init_provider/AbstractHelloWorldResource.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@
4747
*/
4848
public abstract class AbstractHelloWorldResource {
4949

50-
public static final String CONTEXT_ROOT = "/servlet-3-init-provider";
51-
5250
public static final int NUMBER_OF_APPLICATIONS = 5;
5351

5452
@GET

tests/integration/servlet-3-init-provider/src/main/java/org/glassfish/jersey/tests/integration/servlet_3_init_provider/HelloWorld5Resource.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
import javax.ws.rs.GET;
4444
import javax.ws.rs.Path;
4545
import javax.ws.rs.core.Context;
46+
import java.util.Enumeration;
4647

4748
/**
4849
* @author Libor Kramolis (libor.kramolis at oracle.com)

tests/integration/servlet-3-init-provider/src/main/java/org/glassfish/jersey/tests/integration/servlet_3_init_provider/TestFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public void init(FilterConfig filterConfig) throws ServletException {
6161

6262
@Override
6363
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
64-
if (((HttpServletRequest)request).getRequestURI().startsWith(AbstractHelloWorldResource.CONTEXT_ROOT + "/application5")) {
64+
if (((HttpServletRequest)request).getRequestURI().startsWith("/application5")) {
6565
request.setAttribute("FILTER", TestServletContainerProvider.TEST_FILTER);
6666
}
6767

tests/integration/servlet-3-init-provider/src/main/java/org/glassfish/jersey/tests/integration/servlet_3_init_provider/TestServletContainerProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void postInit(ServletContext servletContext, Set<Class<?>> classes, Set<S
7878
public void onRegister(ServletContext servletContext, Set<String> servletNames) throws ServletException {
7979
this.SERVLET_NAMES = servletNames;
8080

81-
servletContext.addFilter("TestFilter", TestFilter.class).
81+
servletContext.addFilter(TEST_FILTER, TestFilter.class).
8282
addMappingForServletNames(EnumSet.allOf(DispatcherType.class), false,
8383
servletNames.toArray(new String[servletNames.size()]));
8484
}

tests/integration/servlet-3-init-provider/src/test/java/org/glassfish/jersey/tests/integration/servlet_3_init_provider/AbstractHelloWorldResourceTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,20 +49,13 @@
4949
import org.junit.Test;
5050
import org.junit.Assert;
5151

52-
import java.net.URI;
5352
import javax.ws.rs.NotFoundException;
54-
import javax.ws.rs.core.UriBuilder;
5553

5654
/**
5755
* @author Libor Kramolis (libor.kramolis at oracle.com)
5856
*/
5957
public abstract class AbstractHelloWorldResourceTest extends JerseyTest {
6058

61-
@Override
62-
protected URI getBaseUri() {
63-
return UriBuilder.fromUri(super.getBaseUri()).path(AbstractHelloWorldResource.CONTEXT_ROOT).build();
64-
}
65-
6659
@Override
6760
protected ResourceConfig configure() {
6861
enable(TestProperties.LOG_TRAFFIC);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
/**
4848
* @author Libor Kramolis (libor.kramolis at oracle.com)
4949
*/
50-
public class HelloWorld1ResourceTest extends AbstractHelloWorldResourceTest {
50+
public class HelloWorld1ResourceITCase extends AbstractHelloWorldResourceTest {
5151

5252
protected Class<?> getResourceClass() {
5353
return HelloWorld1Resource.class;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
/**
4343
* @author Libor Kramolis (libor.kramolis at oracle.com)
4444
*/
45-
public class HelloWorld2ResourceTest extends AbstractHelloWorldResourceTest {
45+
public class HelloWorld2ResourceITCase extends AbstractHelloWorldResourceTest {
4646

4747
protected Class<?> getResourceClass() {
4848
return HelloWorld2Resource.class;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
/**
4848
* @author Libor Kramolis (libor.kramolis at oracle.com)
4949
*/
50-
public class HelloWorld3ResourceTest extends AbstractHelloWorldResourceTest {
50+
public class HelloWorld3ResourceITCase extends AbstractHelloWorldResourceTest {
5151

5252
protected Class<?> getResourceClass() {
5353
return HelloWorld3Resource.class;

0 commit comments

Comments
 (0)