Skip to content

Commit 0211154

Browse files
committed
Merge branch 'issue-115'
2 parents 559716c + c152ffc commit 0211154

File tree

12 files changed

+171
-248
lines changed

12 files changed

+171
-248
lines changed

src/main/java/io/github/fvarrui/javapackager/gradle/GenerateRpm.java

Lines changed: 0 additions & 74 deletions
This file was deleted.

src/main/java/io/github/fvarrui/javapackager/gradle/GradleContext.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,7 @@ public class GradleContext extends Context<Logger> {
2626

2727
public GradleContext(Project project) {
2828
super();
29-
this.project = project;
30-
31-
// gradle dependant generators
32-
this.getLinuxInstallerGenerators().add(new GenerateRpm());
33-
29+
this.project = project;
3430
}
3531

3632
public Logger getLogger() {

src/main/java/io/github/fvarrui/javapackager/maven/GenerateRpm.java

Lines changed: 0 additions & 155 deletions
This file was deleted.

src/main/java/io/github/fvarrui/javapackager/maven/MavenContext.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,8 @@ public class MavenContext extends Context<Log> {
1818

1919
public MavenContext(ExecutionEnvironment env, Log logger) {
2020
super();
21-
2221
this.env = env;
2322
this.logger = logger;
24-
25-
// maven dependant generators
26-
this.getLinuxInstallerGenerators().add(new GenerateRpm());
27-
2823
}
2924

3025
public ExecutionEnvironment getEnv() {

src/main/java/io/github/fvarrui/javapackager/packagers/Context.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,13 @@ public Context() {
1616
super();
1717

1818
// building tool independent generators
19+
1920
linuxInstallerGenerators.add(new GenerateDeb());
21+
linuxInstallerGenerators.add(new GenerateRpm());
22+
2023
macInstallerGenerators.add(new GenerateDmg());
2124
macInstallerGenerators.add(new GeneratePkg());
25+
2226
windowsInstallerGenerators.add(new GenerateSetup());
2327
windowsInstallerGenerators.add(new GenerateMsm());
2428
windowsInstallerGenerators.add(new GenerateMsi());

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateDmg.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import org.apache.commons.lang3.StringUtils;
1010

1111
import io.github.fvarrui.javapackager.model.MacConfig;
12+
import io.github.fvarrui.javapackager.model.Platform;
1213
import io.github.fvarrui.javapackager.utils.FileUtils;
1314
import io.github.fvarrui.javapackager.utils.Logger;
1415
import io.github.fvarrui.javapackager.utils.ThreadUtils;
@@ -26,7 +27,17 @@ public GenerateDmg() {
2627

2728
@Override
2829
public boolean skip(Packager packager) {
29-
return !packager.getMacConfig().isGenerateDmg();
30+
31+
if (!packager.getMacConfig().isGenerateDmg()) {
32+
return true;
33+
}
34+
35+
if (!packager.getPlatform().isCurrentPlatform()) {
36+
Logger.warn(getArtifactName() + " cannot be generated due to the target platform (" + packager.getPlatform() + ") is different from the execution platform (" + Platform.getCurrentPlatform() + ")!");
37+
return true;
38+
}
39+
40+
return false;
3041
}
3142

3243
@Override

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateMsi.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import java.io.File;
66

7+
import io.github.fvarrui.javapackager.model.Platform;
78
import io.github.fvarrui.javapackager.utils.Logger;
89
import io.github.fvarrui.javapackager.utils.VelocityUtils;
910
import io.github.fvarrui.javapackager.utils.XMLUtils;
@@ -20,7 +21,17 @@ public GenerateMsi() {
2021

2122
@Override
2223
public boolean skip(Packager packager) {
23-
return !packager.getWinConfig().isGenerateMsi();
24+
25+
if (!packager.getWinConfig().isGenerateMsi()) {
26+
return true;
27+
}
28+
29+
if (!packager.getPlatform().isCurrentPlatform()) {
30+
Logger.warn(getArtifactName() + " cannot be generated due to the target platform (" + packager.getPlatform() + ") is different from the execution platform (" + Platform.getCurrentPlatform() + ")!");
31+
return true;
32+
}
33+
34+
return false;
2435
}
2536

2637
@Override

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateMsm.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import java.io.File;
44

5+
import io.github.fvarrui.javapackager.model.Platform;
56
import io.github.fvarrui.javapackager.utils.CommandUtils;
67
import io.github.fvarrui.javapackager.utils.Logger;
78
import io.github.fvarrui.javapackager.utils.VelocityUtils;
@@ -19,7 +20,17 @@ public GenerateMsm() {
1920

2021
@Override
2122
public boolean skip(Packager packager) {
22-
return !packager.getWinConfig().isGenerateMsm() && !packager.getWinConfig().isGenerateMsi();
23+
24+
if (!packager.getWinConfig().isGenerateMsm() && !packager.getWinConfig().isGenerateMsi()) {
25+
return true;
26+
}
27+
28+
if (!packager.getPlatform().isCurrentPlatform()) {
29+
Logger.warn(getArtifactName() + " cannot be generated due to the target platform (" + packager.getPlatform() + ") is different from the execution platform (" + Platform.getCurrentPlatform() + ")!");
30+
return true;
31+
}
32+
33+
return false;
2334
}
2435

2536
@Override

src/main/java/io/github/fvarrui/javapackager/packagers/GeneratePkg.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
import java.io.File;
44

5+
import io.github.fvarrui.javapackager.model.Platform;
56
import io.github.fvarrui.javapackager.utils.CommandUtils;
7+
import io.github.fvarrui.javapackager.utils.Logger;
68

79
/**
810
* Creates a PKG installer file including all app folder's content only for MacOS so
@@ -16,7 +18,17 @@ public GeneratePkg() {
1618

1719
@Override
1820
public boolean skip(Packager packager) {
19-
return !packager.getMacConfig().isGeneratePkg();
21+
22+
if (!packager.getMacConfig().isGeneratePkg()) {
23+
return true;
24+
}
25+
26+
if (!packager.getPlatform().isCurrentPlatform()) {
27+
Logger.warn(getArtifactName() + " cannot be generated due to the target platform (" + packager.getPlatform() + ") is different from the execution platform (" + Platform.getCurrentPlatform() + ")!");
28+
return true;
29+
}
30+
31+
return false;
2032
}
2133

2234
@Override

0 commit comments

Comments
 (0)