Skip to content

Commit 704d8ce

Browse files
committed
U fixed packagers generics
1 parent 3cce0e1 commit 704d8ce

File tree

8 files changed

+33
-36
lines changed

8 files changed

+33
-36
lines changed

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateDeb.java

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
* Creates a DEB package file including all app folder's content only for
2121
* GNU/Linux so app could be easily distributed on Gradle context
2222
*/
23-
public class GenerateDeb extends ArtifactGenerator {
23+
public class GenerateDeb extends ArtifactGenerator<LinuxPackager> {
2424

2525
private Console console;
2626

@@ -47,33 +47,31 @@ public void debug(String message) {
4747
}
4848

4949
@Override
50-
public boolean skip(Packager packager) {
50+
public boolean skip(LinuxPackager packager) {
5151
return !packager.getLinuxConfig().isGenerateDeb();
5252
}
5353

5454
@Override
55-
protected File doApply(Packager packager) throws Exception {
55+
protected File doApply(LinuxPackager packager) throws Exception {
5656

57-
LinuxPackager linuxPackager = (LinuxPackager) packager;
58-
59-
File assetsFolder = linuxPackager.getAssetsFolder();
60-
String name = linuxPackager.getName();
61-
File appFolder = linuxPackager.getAppFolder();
62-
File outputDirectory = linuxPackager.getOutputDirectory();
63-
String version = linuxPackager.getVersion();
64-
boolean bundleJre = linuxPackager.getBundleJre();
65-
String jreDirectoryName = linuxPackager.getJreDirectoryName();
66-
File executable = linuxPackager.getExecutable();
57+
File assetsFolder = packager.getAssetsFolder();
58+
String name = packager.getName();
59+
File appFolder = packager.getAppFolder();
60+
File outputDirectory = packager.getOutputDirectory();
61+
String version = packager.getVersion();
62+
boolean bundleJre = packager.getBundleJre();
63+
String jreDirectoryName = packager.getJreDirectoryName();
64+
File executable = packager.getExecutable();
6765
File javaFile = new File(appFolder, jreDirectoryName + "/bin/java");
6866

6967
// generates desktop file from velocity template
7068
File desktopFile = new File(assetsFolder, name + ".desktop");
71-
VelocityUtils.render("linux/desktop.vtl", desktopFile, linuxPackager);
69+
VelocityUtils.render("linux/desktop.vtl", desktopFile, packager);
7270
Logger.info("Desktop file rendered in " + desktopFile.getAbsolutePath());
7371

7472
// generates deb control file from velocity template
7573
File controlFile = new File(assetsFolder, "control");
76-
VelocityUtils.render("linux/control.vtl", controlFile, linuxPackager);
74+
VelocityUtils.render("linux/control.vtl", controlFile, packager);
7775
Logger.info("Control file rendered in " + controlFile.getAbsolutePath());
7876

7977
// generated deb file

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateDmg.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public GenerateDmg() {
2626
}
2727

2828
@Override
29-
public boolean skip(Packager packager) {
29+
public boolean skip(MacPackager packager) {
3030

3131
if (!packager.getMacConfig().isGenerateDmg()) {
3232
return true;

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateMsi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public GenerateMsi() {
2020
}
2121

2222
@Override
23-
public boolean skip(Packager packager) {
23+
public boolean skip(WindowsPackager packager) {
2424

2525
if (!packager.getWinConfig().isGenerateMsi()) {
2626
return true;

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateMsm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public GenerateMsm() {
1919
}
2020

2121
@Override
22-
public boolean skip(Packager packager) {
22+
public boolean skip(WindowsPackager packager) {
2323

2424
if (!packager.getWinConfig().isGenerateMsm() && !packager.getWinConfig().isGenerateMsi()) {
2525
return true;

src/main/java/io/github/fvarrui/javapackager/packagers/GeneratePkg.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public GeneratePkg() {
1717
}
1818

1919
@Override
20-
public boolean skip(Packager packager) {
20+
public boolean skip(MacPackager packager) {
2121

2222
if (!packager.getMacConfig().isGeneratePkg()) {
2323
return true;

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateRpm.java

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,35 +19,33 @@
1919
* Creates a RPM package file including all app folder's content only for
2020
* GNU/Linux so app could be easily distributed on Gradle context
2121
*/
22-
public class GenerateRpm extends ArtifactGenerator {
22+
public class GenerateRpm extends ArtifactGenerator<LinuxPackager> {
2323

2424
public GenerateRpm() {
2525
super("RPM package");
2626
}
2727

2828
@Override
29-
public boolean skip(Packager packager) {
29+
public boolean skip(LinuxPackager packager) {
3030
return !packager.getLinuxConfig().isGenerateRpm();
3131
}
3232

3333
@Override
34-
protected File doApply(Packager packager) throws Exception {
35-
36-
LinuxPackager linuxPackager = (LinuxPackager) packager;
37-
38-
File appFolder = linuxPackager.getAppFolder();
39-
String name = linuxPackager.getName();
40-
String version = linuxPackager.getVersion();
41-
String description = linuxPackager.getDescription();
42-
String organizationName = linuxPackager.getOrganizationName();
43-
File outputDirectory = linuxPackager.getOutputDirectory();
44-
File executable = linuxPackager.getExecutable();
45-
File assetsFolder = linuxPackager.getAssetsFolder();
46-
String jreDirectoryName = linuxPackager.getJreDirectoryName();
34+
protected File doApply(LinuxPackager packager) throws Exception {
35+
36+
File appFolder = packager.getAppFolder();
37+
String name = packager.getName();
38+
String version = packager.getVersion();
39+
String description = packager.getDescription();
40+
String organizationName = packager.getOrganizationName();
41+
File outputDirectory = packager.getOutputDirectory();
42+
File executable = packager.getExecutable();
43+
File assetsFolder = packager.getAssetsFolder();
44+
String jreDirectoryName = packager.getJreDirectoryName();
4745

4846
// generates desktop file from velocity template
4947
File desktopFile = new File(assetsFolder, name + ".desktop");
50-
VelocityUtils.render("linux/desktop.vtl", desktopFile, linuxPackager);
48+
VelocityUtils.render("linux/desktop.vtl", desktopFile, packager);
5149
Logger.info("Rendering desktop file to " + desktopFile.getAbsolutePath());
5250

5351
// copies desktop file to app

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateSetup.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public GenerateSetup() {
2222
}
2323

2424
@Override
25-
public boolean skip(Packager packager) {
25+
public boolean skip(WindowsPackager packager) {
2626

2727
if (!packager.getWinConfig().isGenerateSetup()) {
2828
return true;

src/main/java/io/github/fvarrui/javapackager/packagers/PackagerSettings.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ public class PackagerSettings {
5959
protected String jreMinVersion;
6060
protected Manifest manifest;
6161
protected List<File> additionalModulePaths;
62+
protected List<FileAssociation> fileAssociations;
6263
protected File packagingJdk;
6364

6465
public File getPackagingJdk() {

0 commit comments

Comments
 (0)