Skip to content

Commit a629589

Browse files
authored
Merge pull request #121 from farzadpanahi/master
Search PATH for JRE in Windows
2 parents 92476cd + e6253d4 commit a629589

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

build.gradle

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,16 @@ dependencies {
5050
implementation 'commons-io:commons-io:2.6'
5151
implementation 'org.apache.commons:commons-collections4:4.1'
5252
implementation 'org.apache.velocity:velocity-engine-core:2.0'
53-
implementation 'io.github.fvarrui:gradle-launch4j:2.4.7'
54-
implementation 'com.netflix.nebula:gradle-ospackage-plugin:8.4.1'
55-
implementation 'net.jsign:jsign-core:3.1'
53+
implementation 'io.github.fvarrui:gradle-launch4j:2.4.7'
54+
implementation 'com.netflix.nebula:gradle-ospackage-plugin:8.4.1'
55+
implementation 'net.jsign:jsign-core:3.1'
5656

5757
testImplementation 'junit:junit:4.12'
5858

5959
compileOnly 'org.apache.maven.plugin-tools:maven-plugin-annotations:3.6.0'
60-
61-
mavenEmbedder 'org.apache.maven:maven-embedder:3.6.0'
62-
mavenEmbedder 'org.apache.maven:maven-compat:3.6.0'
60+
61+
mavenEmbedder 'org.apache.maven:maven-embedder:3.6.0'
62+
mavenEmbedder 'org.apache.maven:maven-compat:3.6.0'
6363
mavenEmbedder 'org.slf4j:slf4j-simple:1.7.30'
6464
mavenEmbedder 'org.eclipse.aether:aether-connector-basic:1.1.0'
6565
mavenEmbedder 'org.eclipse.aether:aether-transport-wagon:1.1.0'

src/main/java/io/github/fvarrui/javapackager/gradle/CreateWindowsExe.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ protected File doApply(Packager packager) throws Exception {
6363
l4jTask.setMainClassName(mainClass);
6464
l4jTask.setClasspath(new HashSet<>(windowsPackager.getClasspaths()));
6565
l4jTask.setChdir(useResourcesAsWorkingDir ? "." : "");
66-
l4jTask.setBundledJrePath(bundleJre ? jreDirectoryName : "%JAVA_HOME%");
66+
l4jTask.setBundledJrePath(bundleJre ? jreDirectoryName : "%JAVA_HOME%;%PATH%");
6767
if (!StringUtils.isBlank(jreMinVersion)) {
6868
l4jTask.setJreMinVersion(jreMinVersion);
6969
}

src/main/java/io/github/fvarrui/javapackager/maven/CreateWindowsExe.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected File doApply(Packager packager) {
6868

6969
List<Element> jreElements = new ArrayList<>();
7070
jreElements.add(element("opts", optsElements.toArray(new Element[optsElements.size()])));
71-
jreElements.add(element("path", bundleJre ? jreDirectoryName : "%JAVA_HOME%"));
71+
jreElements.add(element("path", bundleJre ? jreDirectoryName : "%JAVA_HOME%;%PATH%"));
7272
if (!StringUtils.isBlank(jreMinVersion)) {
7373
jreElements.add(element("minVersion", jreMinVersion));
7474
}

0 commit comments

Comments
 (0)