fix: code optimization

Author: javaquery

build.gradle

@@ -5,14 +5,14 @@ plugins {
 }
 
 group 'com.javaquery'
-version '1.0'
+version '1.0.1'
 
 repositories {
     mavenCentral()
 }
 
 dependencies {
-    implementation('org.slf4j:slf4j-api:1.7.30')
+    implementation('org.slf4j:slf4j-api:+')
     testImplementation('org.junit.jupiter:junit-jupiter:5.7.0')
 }
 

src/main/java/com/javaquery/util/collection/Collections.java

@@ -25,7 +25,7 @@ private Collections() {
      * @return {@code true} if the provided Collection [List, Set] is {@code null} or empty
      * otherwise {@code false}
      */
-    public static boolean nullOrEmpty(Collection collection) {
+    public static boolean nullOrEmpty(Collection<?> collection) {
         return Objects.isNull(collection) || collection.isEmpty();
     }
 
@@ -37,7 +37,7 @@ public static boolean nullOrEmpty(Collection collection) {
      * @return {@code true} if the provided Collection [List, Set] is non-{@code null} and non-empty
      * otherwise {@code false}
      */
-    public static boolean nonNullNonEmpty(Collection collection) {
+    public static boolean nonNullNonEmpty(Collection<?> collection) {
         return Objects.nonNull(collection) && !collection.isEmpty();
     }
 
@@ -49,7 +49,7 @@ public static boolean nonNullNonEmpty(Collection collection) {
      * @return {@code true} if the provided Map is {@code null} and empty otherwise
      * * returns {@code false}
      */
-    public static boolean nullOrEmpty(Map map) {
+    public static boolean nullOrEmpty(Map<?, ?> map) {
         return Objects.isNull(map) || map.isEmpty();
     }
 
@@ -61,7 +61,7 @@ public static boolean nullOrEmpty(Map map) {
      * @return {@code true} if the provided Map is non-{@code null} and non-empty
      * otherwise {@code false}
      */
-    public static boolean nonNullNonEmpty(Map map) {
+    public static boolean nonNullNonEmpty(Map<?, ?> map) {
         return Objects.nonNull(map) && !map.isEmpty();
     }
 

src/main/java/com/javaquery/util/io/Files.java

@@ -29,7 +29,7 @@ public final class Files {
      * Note: Exception is logged not thrown.
      *
      * @param file - file to create
-     * @param <T>
+     * @param <T>  the type of class that extends {@link File}
      * @return <code>true</code> if the named file does not exist and was
      * successfully created; <code>false</code> if the named file
      * already exists
@@ -54,7 +54,7 @@ public static <T extends File> boolean createNewFile(T file) {
      * Note: Exception is logged not thrown.
      *
      * @param file - file to delete and create
-     * @param <T>
+     * @param <T>  the type of class that extends {@link File}
      * @return <code>true</code> if the named file deleted and was
      * successfully created; <code>false</code> if the named file
      * already exists
@@ -75,7 +75,7 @@ public static <T extends File> boolean deleteAndCreateNewFile(T file) {
      *
      * @param file file to write
      * @param data data to write to file
-     * @param <T>
+     * @param <T>  the type of class that extends {@link File}
      */
     public static <T extends File> void writeToFile(T file, String data) {
         Assert.nonNull(file, NullPointerException::new);
@@ -100,7 +100,7 @@ public static <T extends File> void writeToFile(T file, String data) {
      * @param data          data to append to file
      * @param appendNewLine <code>true</code> to append new line at the end of data
      *                      otherwise <code>false</code>.
-     * @param <T>
+     * @param <T>           the type of class that extends {@link File}
      */
     public static <T extends File> void appendToFile(T file, String data, boolean appendNewLine) {
         Assert.nonNull(file, NullPointerException::new);
@@ -122,7 +122,7 @@ public static <T extends File> void appendToFile(T file, String data, boolean ap
      * Note: Exception is logged not thrown.
      *
      * @param file file to read
-     * @param <T>
+     * @param <T> the type of class that extends {@link File}
      * @return String data of file if exists otherwise <code>null</code>
      */
     public static <T extends File> String readFromFile(T file) {
@@ -141,7 +141,7 @@ public static <T extends File> String readFromFile(T file) {
      * Path of file provided
      *
      * @param file file to get {@link Path}.
-     * @param <T>
+     * @param <T> the type of class that extends {@link File}
      * @return {@link Path} of file
      */
     private static <T extends File> Path getPath(T file) {

src/main/java/com/javaquery/util/time/DatePattern.java

@@ -35,7 +35,7 @@ public enum DatePattern {
     MMM_DD_YYYY("MMM dd, yyyy"),
     E_D_M_Y_HMS("EEE, dd MMM yyyy HH:mm:ss +0000");
 
-    private String value;
+    private final String value;
 
     DatePattern(String value) {
         this.value = value;

src/main/java/com/javaquery/util/time/Dates.java

@@ -224,7 +224,7 @@ public enum Month {
                 11), DECEMBER(12);
 
         private final static Calendar calendar = Calendar.getInstance();
-        private int value;
+        private final int value;
 
         Month(int value) {
             this.value = value;

src/test/java/com/javaquery/util/collection/TestCollections.java

@@ -4,7 +4,6 @@
 import org.junit.jupiter.api.Test;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;

src/test/java/com/javaquery/util/io/TestFiles.java

@@ -1,6 +1,5 @@
 package com.javaquery.util.io;
 
-import com.javaquery.util.Assert;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;