Skip to content

Commit c9e3956

Browse files
Merge pull request #900 from twbs/main
Create a new pull request by comparing changes across two branches
2 parents fb7fb5b + 0a005b3 commit c9e3956

File tree

710 files changed

+33006
-24325
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

710 files changed

+33006
-24325
lines changed

.browserslistrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ Firefox ESR
99
iOS >= 12
1010
Safari >= 12
1111
not Explorer <= 11
12+
not kaios <= 2.5 # fix floating label issues in Firefox (see https://github.com/postcss/autoprefixer/issues/1533)

.cspell.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
"roboto",
8888
"RTLCSS",
8989
"ruleset",
90+
"sassrc",
9091
"screenreaders",
9192
"scrollbars",
9293
"scrollspy",
@@ -119,9 +120,6 @@
119120
"zindex"
120121
],
121122
"language": "en-US",
122-
"files": [
123-
"**/*.md"
124-
],
125123
"ignorePaths": [
126124
".cspell.json",
127125
"dist/",

.eslintignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
**/dist/
33
**/vendor/
44
/_site/
5+
/site/public/
56
/js/coverage/
67
/site/static/sw.js
8+
/site/static/docs/**/assets/sw.js
79
/site/layouts/partials/

.eslintrc.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@
9595
"unicorn/prefer-array-flat": "off",
9696
"unicorn/prefer-at": "off",
9797
"unicorn/prefer-dom-node-dataset": "off",
98+
"unicorn/prefer-global-this": "off",
9899
"unicorn/prefer-module": "off",
99100
"unicorn/prefer-query-selector": "off",
100101
"unicorn/prefer-spread": "off",
@@ -202,7 +203,12 @@
202203
},
203204
{
204205
"files": [
205-
"site/assets/js/**"
206+
"site/src/assets/application.js",
207+
"site/src/assets/partials/*.js",
208+
"site/src/assets/search.js",
209+
"site/src/assets/snippets.js",
210+
"site/src/assets/stackblitz.js",
211+
"site/src/plugins/*.js"
206212
],
207213
"parserOptions": {
208214
"sourceType": "module",

.github/CONTRIBUTING.md

Lines changed: 36 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Contributing to Bootstrap
22

3-
Looking to contribute something to Bootstrap? **Here's how you can help.**
3+
Looking to contribute something to Bootstrap? **Heres how you can help.**
44

55
Please take a moment to review this document in order to make the contribution
66
process easy and effective for everyone involved.
@@ -33,14 +33,14 @@ restrictions:
3333

3434
## Issues assignment
3535

36-
The core team will be looking at the open issues, analyze them, and provide guidance on how to proceed. **Issues won't be assigned to anyone outside the core team.** However, contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to. Please wait that the issue is ready to be worked on before submitting a PR, we don't want to waste your time.
36+
The core team will be looking at the open issues, analyze them, and provide guidance on how to proceed. **Issues wont be assigned to anyone outside the core team.** However, contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to. Please wait that the issue is ready to be worked on before submitting a PR, we dont want to waste your time.
3737

38-
Please keep in mind that the core team is small, has limited resources and that we are not always able to respond immediately. We will try to provide feedback as soon as possible, but please be patient. If you don't get a response immediately, it doesn't mean that we are ignoring you or that we don't care about your issue or PR. We will get back to you as soon as we can.
38+
Please keep in mind that the core team is small, has limited resources and that we are not always able to respond immediately. We will try to provide feedback as soon as possible, but please be patient. If you dont get a response immediately, it doesnt mean that we are ignoring you or that we dont care about your issue or PR. We will get back to you as soon as we can.
3939

4040

4141
## Issues and labels
4242

43-
Our bug tracker utilizes several labels to help organize and identify issues. Here's what they represent and how we use them:
43+
Our bug tracker utilizes several labels to help organize and identify issues. Heres what they represent and how we use them:
4444

4545
- `browser bug` - Issues that are reported to us, but actually are the result of a browser-specific bug. These are diagnosed with reduced test cases and result in an issue opened on that browser's own bug tracker.
4646
- `confirmed` - Issues that have been confirmed with a reduced test case and identify a bug in Bootstrap.
@@ -64,7 +64,7 @@ Good bug reports are extremely helpful, so thanks!
6464
Guidelines for bug reports:
6565

6666
0. **[Validate your HTML](https://html5.validator.nu/)** to ensure your
67-
problem isn't caused by a simple error in your own code.
67+
problem isnt caused by a simple error in your own code.
6868

6969
1. **Use the GitHub issue search** &mdash; check if the issue has already been
7070
reported.
@@ -77,7 +77,7 @@ Guidelines for bug reports:
7777
These [v4 CodePen](https://codepen.io/team/bootstrap/pen/yLabNQL) and [v5 CodePen](https://codepen.io/team/bootstrap/pen/qBamdLj) are helpful templates.
7878

7979

80-
A good bug report shouldn't leave others needing to chase you up for more
80+
A good bug report shouldnt leave others needing to chase you up for more
8181
information. Please try to be as detailed as possible in your report. What is
8282
your environment? What steps will reproduce the issue? What browser(s) and OS
8383
experience the problem? Do other browsers show the bug differently? What
@@ -109,16 +109,16 @@ Sometimes bugs reported to us are actually caused by bugs in the browser(s) them
109109
| Vendor(s) | Browser(s) | Rendering engine | Bug reporting website(s) | Notes |
110110
| ------------- | ---------------------------- | ---------------- | ------------------------------------------------------ | -------------------------------------------------------- |
111111
| Mozilla | Firefox | Gecko | <https://bugzilla.mozilla.org/enter_bug.cgi> | "Core" is normally the right product option to choose. |
112-
| Apple | Safari | WebKit | <https://bugs.webkit.org/enter_bug.cgi?product=WebKit> | In Apple's bug reporter, choose "Safari" as the product. |
112+
| Apple | Safari | WebKit | <https://bugs.webkit.org/enter_bug.cgi?product=WebKit> | In Apples bug reporter, choose "Safari" as the product. |
113113
| Google, Opera | Chrome, Chromium, Opera v15+ | Blink | <https://bugs.chromium.org/p/chromium/issues/list> | Click the "New issue" button. |
114114
| Microsoft | Edge | Blink | <https://developer.microsoft.com/en-us/microsoft-edge/> | Go to "Help > Send Feedback" from the browser |
115115

116116

117117
## Feature requests
118118

119119
Feature requests are welcome. But take a moment to find out whether your idea
120-
fits with the scope and aims of the project. It's up to _you_ to make a strong
121-
case to convince the project's developers of the merits of this feature. Please
120+
fits with the scope and aims of the project. Its up to _you_ to make a strong
121+
case to convince the projects developers of the merits of this feature. Please
122122
provide as much detail and context as possible.
123123

124124

@@ -131,8 +131,8 @@ commits.
131131
**Please ask first** before embarking on any **significant** pull request (e.g.
132132
implementing features, refactoring code, porting to a different language),
133133
otherwise you risk spending a lot of time working on something that the
134-
project's developers might not want to merge into the project. For trivial
135-
things, or things that don't require a lot of your time, you can go ahead and
134+
projects developers might not want to merge into the project. For trivial
135+
things, or things that dont require a lot of your time, you can go ahead and
136136
make a PR.
137137

138138
Please adhere to the [coding guidelines](#code-guidelines) used throughout the
@@ -144,7 +144,7 @@ any dist files (`dist/` or `js/dist`).** Those files are automatically generated
144144
edit the source files in [`/bootstrap/scss/`](https://github.com/twbs/bootstrap/tree/main/scss)
145145
and/or [`/bootstrap/js/src/`](https://github.com/twbs/bootstrap/tree/main/js/src) instead.
146146

147-
Similarly, when contributing to Bootstrap's documentation, you should edit the
147+
Similarly, when contributing to Bootstraps documentation, you should edit the
148148
documentation source files in
149149
[the `/bootstrap/site/content/docs/` directory of the `main` branch](https://github.com/twbs/bootstrap/tree/main/site/content/docs).
150150
**Do not edit the `gh-pages` branch.** That branch is generated from the
@@ -172,33 +172,47 @@ included in the project:
172172
git pull upstream main
173173
```
174174

175-
3. Create a new topic branch (off the main project development branch) to
175+
3. Install or update project dependencies with npm:
176+
177+
```bash
178+
npm install
179+
```
180+
181+
4. Create a new topic branch (off the main project development branch) to
176182
contain your feature, change, or fix:
177183

178184
```bash
179185
git checkout -b <topic-branch-name>
180186
```
181187

182-
4. Commit your changes in logical chunks. Please adhere to these [git commit
188+
5. Commit your changes in logical chunks. Please adhere to these [git commit
183189
message guidelines](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
184-
or your code is unlikely be merged into the main project. Use Git's
190+
or your code is unlikely be merged into the main project. Use Gits
185191
[interactive rebase](https://help.github.com/articles/about-git-rebase/)
186192
feature to tidy up your commits before making them public.
187193

188-
5. Locally merge (or rebase) the upstream development branch into your topic branch:
194+
6. Ensure your changes compile the dist CSS and JS files in the `dist/` directory. Verify
195+
the build succeeds locally without errors.
196+
197+
```bash
198+
npm run dist
199+
```
200+
201+
7. Locally merge (or rebase) the upstream development branch into your topic branch:
189202

190203
```bash
191204
git pull [--rebase] upstream main
192205
```
193206

194-
6. Push your topic branch up to your fork:
207+
8. Commit your changes, but **do not push compiled CSS and JS files in `dist` and `js/dist`**.
208+
Push your topic branch up to your fork:
195209

196210
```bash
197211
git push origin <topic-branch-name>
198212
```
199213

200-
7. [Open a Pull Request](https://help.github.com/articles/about-pull-requests/)
201-
with a clear title and description against the `main` branch.
214+
9. [Open a pull request](https://help.github.com/articles/about-pull-requests/)
215+
with a clear title and description against the `main` branch.
202216

203217
**IMPORTANT**: By submitting a patch, you agree to allow the project owners to
204218
license your work under the terms of the [MIT License](../LICENSE) (if it
@@ -214,15 +228,15 @@ includes code changes) and under the terms of the
214228
[Adhere to the Code Guide.](https://codeguide.co/#html)
215229

216230
- Use tags and elements appropriate for an HTML5 doctype (e.g., self-closing tags).
217-
- Use CDNs and HTTPS for third-party JS when possible. We don't use protocol-relative URLs in this case because they break when viewing the page locally via `file://`.
231+
- Use CDNs and HTTPS for third-party JS when possible. We dont use protocol-relative URLs in this case because they break when viewing the page locally via `file://`.
218232
- Use [WAI-ARIA](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA) attributes in documentation examples to promote accessibility.
219233

220234
### CSS
221235

222236
[Adhere to the Code Guide.](https://codeguide.co/#css)
223237

224238
- When feasible, default color palettes should comply with [WCAG color contrast guidelines](https://www.w3.org/TR/WCAG/#distinguishable).
225-
- Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](https://www.a11yproject.com/posts/2013-01-25-never-remove-css-outlines/) for more details.
239+
- Except in rare cases, dont remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](https://www.a11yproject.com/posts/2013-01-25-never-remove-css-outlines/) for more details.
226240

227241
### JS
228242

@@ -241,4 +255,4 @@ Run `npm run test` before committing to ensure your changes follow our coding st
241255
By contributing your code, you agree to license your contribution under the [MIT License](../LICENSE).
242256
By contributing to the documentation, you agree to license your contribution under the [Creative Commons Attribution 3.0 Unported License](https://creativecommons.org/licenses/by/3.0/).
243257

244-
Prior to v3.1.0, Bootstrap's code was released under the Apache License v2.0.
258+
Prior to v3.1.0, Bootstraps code was released under the Apache License v2.0.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
### Checklist
1919

2020
<!-- Go over all the following points, and put an `x` in all the boxes that apply. -->
21-
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
21+
<!-- If youre unsure about any of these, dont hesitate to ask. Were here to help! -->
2222

2323
- [ ] I have read the [contributing guidelines](https://github.com/twbs/bootstrap/blob/main/.github/CONTRIBUTING.md)
2424
- [ ] My code follows the code style of the project _(using `npm run lint`)_

.github/dependabot.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ updates:
99
timezone: Europe/Athens
1010
- package-ecosystem: npm
1111
directory: "/"
12-
reviewers:
13-
- XhmikosR
1412
labels:
1513
- dependencies
1614
- v5

.github/workflows/cspell.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ jobs:
2828
persist-credentials: false
2929

3030
- name: Run cspell
31-
uses: streetsidesoftware/cspell-action@v6
31+
uses: streetsidesoftware/cspell-action@v7
3232
with:
3333
config: ".cspell.json"
34-
files: "**/*.md"
34+
files: "**/*.{md,mdx}"
3535
inline: error
3636
incremental_files_only: false

.gitignore

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
# Ignore docs files
22
/_site/
3-
# Hugo files
4-
/resources/
5-
/.hugo_build.lock
63

74
# Numerous always-ignore extensions
85
*.diff
@@ -41,3 +38,9 @@ Thumbs.db
4138
/dist-sass/
4239
/js/coverage/
4340
/node_modules/
41+
42+
# Site
43+
/site/dist
44+
/site/node_modules
45+
/site/.astro
46+
/site/public

.prettierignore

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# Prettier is only used for the website
2+
3+
site/.astro
4+
site/dist
5+
site/public
6+
site/src/assets
7+
site/src/scss
8+
site/src/pages/**/*.md
9+
site/src/pages/**/*.mdx
10+
site/src/content/**/*.mdx
11+
site/src/layouts/RedirectLayout.astro
12+
site/static

0 commit comments

Comments
 (0)