Skip to content

Commit fecd219

Browse files
bbonchdmitrysergienkocodefirstjulien-deramond
authored
Fix popover remaining open when toggled after being shown (twbs#40803)
Co-authored-by: Dmitry Sergienko <[email protected]> Co-authored-by: Julien Déramond <[email protected]>
1 parent dcec1df commit fecd219

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

js/src/tooltip.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ class Tooltip extends BaseComponent {
160160
return
161161
}
162162

163-
this._activeTrigger.click = !this._activeTrigger.click
164163
if (this._isShown()) {
165164
this._leave()
166165
return

js/tests/unit/popover.spec.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,26 @@ describe('Popover', () => {
5656
})
5757

5858
describe('show', () => {
59+
it('should toggle a popover after show', () => {
60+
return new Promise(resolve => {
61+
fixtureEl.innerHTML = '<a href="#" title="Popover" data-bs-content="https://twitter.com/getbootstrap">BS twitter</a>'
62+
63+
const popoverEl = fixtureEl.querySelector('a')
64+
const popover = new Popover(popoverEl)
65+
66+
popoverEl.addEventListener('shown.bs.popover', () => {
67+
expect(document.querySelector('.popover')).not.toBeNull()
68+
popover.toggle()
69+
})
70+
popoverEl.addEventListener('hidden.bs.popover', () => {
71+
expect(document.querySelector('.popover')).toBeNull()
72+
resolve()
73+
})
74+
75+
popover.show()
76+
})
77+
})
78+
5979
it('should show a popover', () => {
6080
return new Promise(resolve => {
6181
fixtureEl.innerHTML = '<a href="#" title="Popover" data-bs-content="https://twitter.com/getbootstrap">BS twitter</a>'

0 commit comments

Comments
 (0)