fix(bundle): don't use createRequire when targeting browser in Deno.bundle (denoland#31534)

Fixes denoland#31524

Missed a code path in the original fix

Author: nathanwhit

cli/tools/bundle/provider.rs

@@ -173,7 +173,9 @@ impl BundleProvider for CliBundleProvider {
           super::process_result(
             &result,
             &bundler.cwd,
-            true,
+            crate::tools::bundle::should_replace_require_shim(
+              bundle_flags.platform,
+            ),
             bundle_flags.minify,
             bundler.input,
             bundle_flags.output_dir.as_ref().map(Path::new),

tests/specs/bundle/require_browser/__test__.jsonc

@@ -0,0 +1,29 @@
+{
+  "tempDir": true,
+  "tests": {
+    "api": {
+      "steps": [
+        {
+          "args": "run --unstable-bundle bundle.ts",
+          "output": "[WILDCARD]"
+        },
+        {
+          "args": "run -A has-createrequire.ts bundle.js",
+          "output": "false\n"
+        }
+      ]
+    },
+    "cli": {
+      "steps": [
+        {
+          "args": "bundle --platform browser --output bundle.js foo.cjs",
+          "output": "[WILDCARD]"
+        },
+        {
+          "args": "run -A has-createrequire.ts bundle.js",
+          "output": "false\n"
+        }
+      ]
+    }
+  }
+}

tests/specs/bundle/require_browser/bundle.ts

@@ -0,0 +1,5 @@
+await Deno.bundle({
+  entrypoints: ["./foo.cjs"],
+  platform: "browser",
+  outputPath: "bundle.js",
+});

tests/specs/bundle/require_browser/foo.cjs

@@ -0,0 +1,11 @@
+let arch;
+if (typeof globalThis.window !== "undefined") {
+  const os = require("node:os");
+  arch = os.arch;
+} else {
+  arch = "browser";
+}
+module.exports = {
+  hi: "hi",
+  arch,
+};

tests/specs/bundle/require_browser/has-createrequire.ts

@@ -0,0 +1,9 @@
+const file = Deno.args[0];
+
+const contents = Deno.readTextFileSync(file);
+
+if (contents.includes("createRequire")) {
+  console.log("true");
+} else {
+  console.log("false");
+}