Skip to content

Commit 888ab9f

Browse files
authored
test(ext/node): disable flaky dgram tests (denoland#27549)
Closes denoland#27316
1 parent f483996 commit 888ab9f

File tree

5 files changed

+9
-122
lines changed

5 files changed

+9
-122
lines changed

tests/node_compat/config.jsonc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,9 +368,11 @@
368368
"test-dgram-send-callback-multi-buffer.js",
369369
"test-dgram-send-callback-recursive.js",
370370
"test-dgram-send-default-host.js",
371-
"test-dgram-send-empty-array.js",
372-
"test-dgram-send-empty-buffer.js",
373-
"test-dgram-send-empty-packet.js",
371+
// TODO(kt3k): These tests are flaky on macOS CI.
372+
// https://github.com/denoland/deno/issues/27316
373+
// "test-dgram-send-empty-array.js",
374+
// "test-dgram-send-empty-buffer.js",
375+
// "test-dgram-send-empty-packet.js",
374376
"test-dgram-send-error.js",
375377
"test-dgram-send-invalid-msg-type.js",
376378
"test-dgram-send-multi-buffer-copy.js",

tests/node_compat/runner/TODO.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!-- deno-fmt-ignore-file -->
22
# Remaining Node Tests
33

4-
1155 tests out of 3681 have been ported from Node 20.11.1 (31.38% ported, 69.14% remaining).
4+
1152 tests out of 3681 have been ported from Node 20.11.1 (31.30% ported, 69.22% remaining).
55

66
NOTE: This file should not be manually edited. Please edit `tests/node_compat/config.json` and run `deno task setup` in `tests/node_compat/runner` dir instead.
77

@@ -499,6 +499,9 @@ NOTE: This file should not be manually edited. Please edit `tests/node_compat/co
499499
- [parallel/test-dgram-multicast-set-interface.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-multicast-set-interface.js)
500500
- [parallel/test-dgram-multicast-setTTL.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-multicast-setTTL.js)
501501
- [parallel/test-dgram-send-address-types.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-send-address-types.js)
502+
- [parallel/test-dgram-send-empty-array.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-send-empty-array.js)
503+
- [parallel/test-dgram-send-empty-buffer.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-send-empty-buffer.js)
504+
- [parallel/test-dgram-send-empty-packet.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-send-empty-packet.js)
502505
- [parallel/test-dgram-send-queue-info.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-send-queue-info.js)
503506
- [parallel/test-dgram-sendto.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-sendto.js)
504507
- [parallel/test-dgram-setBroadcast.js](https://github.com/nodejs/node/tree/v20.11.1/test/parallel/test-dgram-setBroadcast.js)

tests/node_compat/test/parallel/test-dgram-send-empty-array.js

Lines changed: 0 additions & 32 deletions
This file was deleted.

tests/node_compat/test/parallel/test-dgram-send-empty-buffer.js

Lines changed: 0 additions & 50 deletions
This file was deleted.

tests/node_compat/test/parallel/test-dgram-send-empty-packet.js

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)