fix(install): duplicate dependencies in package.json (denoland#26128)

Fixes denoland#26120

Author: marvinhagemeister

cli/tools/registry/pm.rs

@@ -130,8 +130,10 @@ impl NpmConfig {
   fn add(&mut self, selected: SelectedPackage, dev: bool) {
     let (name, version) = package_json_dependency_entry(selected);
     if dev {
+      self.dependencies.swap_remove(&name);
       self.dev_dependencies.insert(name, version);
     } else {
+      self.dev_dependencies.swap_remove(&name);
       self.dependencies.insert(name, version);
     }
   }

tests/specs/install/install_add_dep_existing/__test__.jsonc

@@ -0,0 +1,16 @@
+{
+  "tempDir": true,
+  "steps": [
+    {
+      "args": "install npm:@denotest/esm-basic",
+      "output": "install.out"
+    },
+    {
+      "args": [
+        "eval",
+        "console.log(Deno.readTextFileSync('package.json').trim())"
+      ],
+      "output": "package.json.out"
+    }
+  ]
+}

tests/specs/install/install_add_dep_existing/install.out

@@ -0,0 +1,4 @@
+Add npm:@denotest/[email protected]
+Download http://localhost:4260/@denotest/esm-basic
+Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
+Initialize @denotest/[email protected]

tests/specs/install/install_add_dep_existing/package.json

@@ -0,0 +1,3 @@
+{
+  "devDependencies": { "@denotest/esm-basic": "^1.0.0" }
+}

tests/specs/install/install_add_dep_existing/package.json.out

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "@denotest/esm-basic": "^1.0.0"
+  }
+}

tests/specs/install/install_add_dev_existing/__test__.jsonc

@@ -0,0 +1,16 @@
+{
+  "tempDir": true,
+  "steps": [
+    {
+      "args": "install --dev npm:@denotest/esm-basic",
+      "output": "install.out"
+    },
+    {
+      "args": [
+        "eval",
+        "console.log(Deno.readTextFileSync('package.json').trim())"
+      ],
+      "output": "package.json.out"
+    }
+  ]
+}

tests/specs/install/install_add_dev_existing/install.out

@@ -0,0 +1,4 @@
+Add npm:@denotest/[email protected]
+Download http://localhost:4260/@denotest/esm-basic
+Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
+Initialize @denotest/[email protected]

tests/specs/install/install_add_dev_existing/package.json

@@ -0,0 +1,3 @@
+{
+  "dependencies": { "@denotest/esm-basic": "^1.0.0" }
+}

tests/specs/install/install_add_dev_existing/package.json.out

@@ -0,0 +1,5 @@
+{
+  "devDependencies": {
+    "@denotest/esm-basic": "^1.0.0"
+  }
+}