Skip to content

Commit 5afa16a

Browse files
authored
fix(curriculum):Added return inside map from step-25 to 45 and test for checking space between isCaptain and name (freeCodeCamp#56918)
1 parent 46619eb commit 5afa16a

21 files changed

+60
-52
lines changed

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e954321b0a77ae4f6d9650.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@ dashedName: step-25
77

88
# --description--
99

10-
Inside the body of the callback function, you will need to add template literals ``` `` ``` which will contain the HTML content for the player cards.
10+
Inside the body of the callback function, you will need to return a template literal ``` `` ``` which will contain the HTML content for the player cards.
1111

1212
Inside the template literals, add an empty `div` with a class of `"player-card"`.
1313

1414
# --hints--
1515

16-
You should use template literals to add an empty `div` with a class of `"player-card"`.
16+
The `map` callback should return a template literal that contains an empty `div` with a class of `"player-card"`.
1717

1818

1919
```js
2020

21-
assert.match(code, /`\s*<div\s+class=("|')\s*player-card\s*\1\s*>\s*<\/div>\s*`\s*/)
21+
assert.match(code, /return\s*`\s*<div\s+class=("|')\s*player-card\s*\1\s*>\s*<\/div>\s*`\s*/)
2222

2323
```
2424

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e95a45dce95baf41dd4f78.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ const setPlayerCards = (arr = players) => {
460460

461461
playerCards.innerHTML += arr.map(
462462
({ name, position, number, isCaptain, nickname }) => {
463-
`
463+
return `
464464
<div class="player-card">
465465
466466
</div>

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e95e39860dc5b01ebe9be0.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@ You should use a ternary operator to check if `isCaptain` is true and return `"(
1919
assert.match(code, /\s*<h2\s*>\s*\$\{isCaptain(\s*===\s*true)?\s*\?\s*('|"|`)\(Captain\)\2\s*:\s*('|"|`)\3\}\s*\${\s*name\s*}\s*<\/h2>\s*/)
2020
```
2121

22+
You should give a space between `"(Captain)"` and `name`.
23+
24+
```js
25+
playerCards.innerHTML = '';
26+
setPlayerCards([{name: "Diego Maradona", isCaptain: true}])
27+
assert.equal(document.querySelector(".player-card h2").innerText, '(Captain) Diego Maradona')
28+
```
29+
2230
# --seed--
2331

2432
## --seed-contents--
@@ -452,7 +460,7 @@ const setPlayerCards = (arr = players) => {
452460

453461
playerCards.innerHTML += arr.map(
454462
({ name, position, number, isCaptain, nickname }) => {
455-
`
463+
return `
456464
<div class="player-card">
457465
<h2>${name}</h2>
458466
</div>

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e9667c881b61b1e338d276.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ const setPlayerCards = (arr = players) => {
456456

457457
playerCards.innerHTML += arr.map(
458458
({ name, position, number, isCaptain, nickname }) => {
459-
`
459+
return `
460460
<div class="player-card">
461461
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
462462

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e96938d2a347b2734a1587.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ const setPlayerCards = (arr = players) => {
456456

457457
playerCards.innerHTML += arr.map(
458458
({ name, position, number, isCaptain, nickname }) => {
459-
`
459+
return `
460460
<div class="player-card">
461461
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
462462
<p>Position: ${position}</p>

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e96eb94c97b6b31ee50f63.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ const setPlayerCards = (arr = players) => {
456456

457457
playerCards.innerHTML += arr.map(
458458
({ name, position, number, isCaptain, nickname }) => {
459-
`
459+
return `
460460
<div class="player-card">
461461
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
462462
<p>Position: ${position}</p>

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e9718d7d490bb3940d5a0a.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ const setPlayerCards = (arr = players) => {
464464

465465
playerCards.innerHTML += arr.map(
466466
({ name, position, number, isCaptain, nickname }) => {
467-
`
467+
return `
468468
<div class="player-card">
469469
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
470470
<p>Position: ${position}</p>

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63e9737f686c76b4078a60f4.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ const setPlayerCards = (arr = players) => {
459459

460460
playerCards.innerHTML += arr.map(
461461
({ name, position, number, isCaptain, nickname }) => {
462-
`
462+
return `
463463
<div class="player-card">
464464
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
465465
<p>Position: ${position}</p>

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63f28972973504e7bb58b0b3.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -461,15 +461,15 @@ headCoach.textContent = coachName;
461461
const setPlayerCards = (arr = players) => {
462462
playerCards.innerHTML += arr
463463
.map(
464-
({ name, position, number, isCaptain, nickname }) =>
465-
`
464+
({ name, position, number, isCaptain, nickname }) => {
465+
return `
466466
<div class="player-card">
467467
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
468468
<p>Position: ${position}</p>
469469
<p>Number: ${number}</p>
470470
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
471471
</div>
472-
`
472+
` }
473473
)
474474
.join("");
475475
};

curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-modern-javascript-methods-by-building-football-team-cards/63f28ef082d771e8bf71f94a.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -449,15 +449,15 @@ headCoach.textContent = coachName;
449449
const setPlayerCards = (arr = players) => {
450450
playerCards.innerHTML += arr
451451
.map(
452-
({ name, position, number, isCaptain, nickname }) =>
453-
`
452+
({ name, position, number, isCaptain, nickname }) => {
453+
return `
454454
<div class="player-card">
455455
<h2>${isCaptain ? "(Captain)" : ""} ${name}</h2>
456456
<p>Position: ${position}</p>
457457
<p>Number: ${number}</p>
458458
<p>Nickname: ${nickname !== null ? nickname : "N/A"}</p>
459459
</div>
460-
`
460+
` }
461461
)
462462
.join("");
463463
};

0 commit comments

Comments
 (0)