Merge pull request #1015 from nodejs/main

Create a new pull request by comparing changes across two branches

Author: GulajavaMinistudio

.github/CODEOWNERS

@@ -167,6 +167,7 @@
 /doc/api/permissions.md @nodejs/security-wg
 /lib/internal/process/permission.js @nodejs/security-wg
 /src/permission/* @nodejs/security-wg
+/test/parallel/test-permission-* @nodejs/security-wg
 
 # Dependency Update Tools
 

benchmark/fs/bench-chownSync.js

@@ -45,7 +45,7 @@ function main({ n, type, method }) {
         }
       }
       bench.end(n);
-      assert(hasError);
+      assert.ok(hasError);
       break;
     }
     default:

benchmark/fs/bench-linkSync.js

@@ -41,7 +41,7 @@ function main({ n, type }) {
         }
       }
       bench.end(n);
-      assert(hasError);
+      assert.ok(hasError);
       break;
     }
     default:

benchmark/fs/bench-readlinkSync.js

@@ -30,7 +30,7 @@ function main({ n, type }) {
         returnValue = fs.readlinkSync(tmpdir.resolve(`.readlink-sync-${i}`), { encoding: 'utf8' });
       }
       bench.end(n);
-      assert(returnValue);
+      assert.ok(returnValue);
       break;
     }
 
@@ -45,7 +45,7 @@ function main({ n, type }) {
         }
       }
       bench.end(n);
-      assert(hasError);
+      assert.ok(hasError);
       break;
     }
     default:

benchmark/fs/bench-readvSync.js

@@ -49,7 +49,7 @@ function main({ n, type }) {
       }
 
       bench.end(n);
-      assert(hasError);
+      assert.ok(hasError);
       break;
     }
     default:

benchmark/fs/bench-renameSync.js

@@ -23,7 +23,7 @@ function main({ n, type }) {
         }
       }
       bench.end(n);
-      assert(hasError);
+      assert.ok(hasError);
       break;
     }
     case 'valid': {

benchmark/fs/bench-symlinkSync.js

@@ -42,7 +42,7 @@ function main({ n, type }) {
         }
       }
       bench.end(n);
-      assert(hasError);
+      assert.ok(hasError);
       break;
     }
     default:

benchmark/fs/bench-writevSync.js

@@ -30,7 +30,7 @@ function main({ n, type }) {
       }
 
       bench.end(n);
-      assert(result);
+      assert.ok(result);
       fs.closeSync(fd);
       break;
     case 'invalid': {
@@ -46,7 +46,7 @@ function main({ n, type }) {
       }
 
       bench.end(n);
-      assert(hasError);
+      assert.ok(hasError);
       break;
     }
     default:

benchmark/fs/read-stream-throughput.js

@@ -67,7 +67,7 @@ function main(conf) {
 }
 
 function runTest(filesize, highWaterMark, encoding, n) {
-  assert(fs.statSync(filename).size === filesize * n);
+  assert.strictEqual(fs.statSync(filename).size, filesize * n);
   const rs = fs.createReadStream(filename, {
     highWaterMark,
     encoding,

benchmark/misc/startup-cli-version.js

@@ -18,12 +18,12 @@ const availableCli = [
 ].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli)));
 const bench = common.createBenchmark(main, {
   cli: availableCli,
-  count: [30],
+  n: [30],
 });
 
 function spawnProcess(cli, bench, state) {
   const cmd = process.execPath || process.argv[0];
-  while (state.finished < state.count) {
+  while (state.finished < state.n) {
     const child = spawnSync(cmd, [cli, '--version'], {
       env: { npm_config_loglevel: 'silent', ...process.env },
     });
@@ -41,15 +41,15 @@ function spawnProcess(cli, bench, state) {
       bench.start();
     }
 
-    if (state.finished === state.count) {
-      bench.end(state.count);
+    if (state.finished === state.n) {
+      bench.end(state.n);
     }
   }
 }
 
-function main({ count, cli }) {
+function main({ n, cli }) {
   cli = path.resolve(__dirname, '../../', cli);
   const warmup = 3;
-  const state = { count, finished: -warmup };
+  const state = { n, finished: -warmup };
   spawnProcess(cli, bench, state);
 }