Merge pull request #1043 from nodejs/main

Create a new pull request by comparing changes across two branches

Author: GulajavaMinistudio

.devcontainer/base/devcontainer.json

@@ -0,0 +1,11 @@
+{
+  "name": "Node.js Dev Container",
+  "image": "nodejs/devcontainer:nightly",
+  "workspaceMount": "source=${localWorkspaceFolder},target=/home/developer/nodejs/node,type=bind,consistency=cached",
+  "workspaceFolder": "/home/developer/nodejs/node",
+  "remoteUser": "developer",
+  "mounts": [
+    "source=node-devcontainer-cache,target=/home/developer/nodejs/node/out,type=volume"
+  ],
+  "postCreateCommand": "git restore-mtime"
+}

.devcontainer/devcontainer.json

@@ -18,6 +18,7 @@
 /doc/contributing/**/* @nodejs/tsc
 /GOVERNANCE.md @nodejs/tsc
 /SECURITY.md @nodejs/tsc
+/BUILDING.md @nodejs/build @nodejs/tsc
 /LICENSE @nodejs/tsc
 /onboarding.md @nodejs/tsc
 
@@ -157,8 +158,7 @@
 /doc/contributing/maintaining/maintaining-single-executable-application-support.md @nodejs/single-executable
 /src/node_sea* @nodejs/single-executable
 /test/fixtures/postject-copy @nodejs/single-executable
-/test/parallel/test-single-executable-* @nodejs/single-executable
-/test/sequential/test-single-executable-* @nodejs/single-executable
+/test/sea @nodejs/single-executable
 /tools/dep_updaters/update-postject.sh @nodejs/single-executable
 
 # Permission Model
@@ -216,3 +216,22 @@
 /src/node_options.* @nodejs/config
 /test/parallel/test-config-* @nodejs/config
 /test/parallel/test-dotenv-* @nodejs/config
+
+# Inspector
+/src/inspector/* @nodejs/inspector
+/src/inspector_* @nodejs/inspector
+/lib/internal/inspector/* @nodejs/inspector
+/lib/internal/inspector_* @nodejs/inspector
+/lib/inspector.js @nodejs/inspector
+
+# path
+/lib/path.js @nodejs/path
+/lib/path/* @nodejs/path
+/test/parallel/test-path-* @nodejs/path
+
+# userland-migrations
+/doc/api/deprecations.md @nodejs/userland-migrations
+
+# dev container
+/.devcontainer/* @nodejs/devcontainer
+/doc/contributing/using-devcontainer.md @nodejs/devcontainer

.github/CODEOWNERS

@@ -0,0 +1,15 @@
+name: Install Clang
+description: Installs a specific Clang version. Useful if the GitHub runner does not have it by default.
+inputs:
+  clang-version:
+    description: The Clang major version to install
+    required: true
+
+runs:
+  using: composite
+  steps:
+    - name: Install Clang
+      shell: bash
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y clang-${{ inputs.clang-version }}

.github/actions/install-clang/action.yml

@@ -2,5 +2,5 @@ name: CodeQL config
 
 paths-ignore:
   - test
-  - deps/v8/test
-  - deps/v8/tools
+  - deps
+  - benchmark

.github/codeql-config.yml

@@ -6,17 +6,25 @@ updates:
     directory: /
     schedule:
       interval: monthly
+    cooldown:
+      semver-major-days: 5
+      semver-minor-days: 5
+      semver-patch-days: 5
     commit-message:
       prefix: meta
-    open-pull-requests-limit: ${{secrets.OPEN_PR_LIMIT}}
+    open-pull-requests-limit: 10
 
   - package-ecosystem: npm
     directory: /tools/eslint
     schedule:
       interval: monthly
+    cooldown:
+      semver-major-days: 5
+      semver-minor-days: 5
+      semver-patch-days: 5
     commit-message:
       prefix: tools
-    open-pull-requests-limit: ${{secrets.OPEN_PR_LIMIT}}
+    open-pull-requests-limit: 10
     groups:
       eslint:
         applies-to: version-updates
@@ -27,11 +35,32 @@ updates:
     directory: /tools/lint-md
     schedule:
       interval: monthly
+    cooldown:
+      semver-major-days: 5
+      semver-minor-days: 5
+      semver-patch-days: 5
     commit-message:
       prefix: tools
-    open-pull-requests-limit: ${{secrets.OPEN_PR_LIMIT}}
+    open-pull-requests-limit: 10
     groups:
       lint-md:
         applies-to: version-updates
         patterns:
           - '*'
+
+  - package-ecosystem: npm
+    directory: /tools/doc
+    schedule:
+      interval: weekly
+    cooldown:
+      semver-major-days: 5
+      semver-minor-days: 5
+      semver-patch-days: 5
+    commit-message:
+      prefix: tools
+    open-pull-requests-limit: 10
+    groups:
+      doc:
+        applies-to: version-updates
+        patterns:
+          - '*'

.github/dependabot.yml

@@ -45,12 +45,12 @@ jobs:
     if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
         with:
           persist-credentials: false
 
       - name: Install Node.js
-        uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020  # v4.4.0
+        uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903  # v6.0.0
         with:
           node-version: ${{ env.NODE_VERSION }}
 

.github/workflows/auto-start-ci.yml

@@ -8,6 +8,7 @@ on:
       - '**.md'
       - AUTHORS
       - doc/**
+      - test/internet/**
       - .github/**
       - '!.github/workflows/build-tarball.yml'
   push:
@@ -20,6 +21,7 @@ on:
       - '**.md'
       - AUTHORS
       - doc/**
+      - test/internet/**
       - .github/**
       - '!.github/workflows/build-tarball.yml'
 
@@ -28,11 +30,9 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.12'
+  PYTHON_VERSION: '3.14'
   FLAKY_TESTS: keep_retrying
-  CC: sccache clang
-  CXX: sccache clang++
-  SCCACHE_GHA_ENABLED: 'true'
+  CLANG_VERSION: '19'
 
 permissions:
   contents: read
@@ -42,67 +42,66 @@ jobs:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065  # v5.6.0
+        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c  # v6.0.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
-      - name: Set up sccache
-        uses: Mozilla-Actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad  # v0.0.9
-        with:
-          version: v0.10.0
+          allow-prereleases: true
       - name: Environment Information
         run: npx envinfo
       - name: Make tarball
         run: |
           export DISTTYPE=nightly
-          export DATESTRING=`date "+%Y-%m-%d"`
+          export DATESTRING=$(date "+%Y-%m-%d")
           export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
-          ./configure && make tar -j8 SKIP_XZ=1
-          mkdir tarballs
-          mv *.tar.gz tarballs
+          ./configure && make tar -j4 SKIP_XZ=1
       - name: Upload tarball artifact
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4.6.2
+        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4  # v5.0.0
         with:
           name: tarballs
-          path: tarballs
+          path: '*.tar.gz'
+          compression-level: 0
   test-tarball-linux:
     needs: build-tarball
     runs-on: ubuntu-24.04
+    env:
+      CC: sccache clang-19
+      CXX: sccache clang++-19
+      SCCACHE_GHA_ENABLED: 'true'
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
         with:
           persist-credentials: false
+          sparse-checkout: .github/actions/install-clang
+          sparse-checkout-cone-mode: false
+      - name: Install Clang ${{ env.CLANG_VERSION }}
+        uses: ./.github/actions/install-clang
+        with:
+          clang-version: ${{ env.CLANG_VERSION }}
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065  # v5.6.0
+        uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c  # v6.0.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
+          allow-prereleases: true
       - name: Set up sccache
         uses: Mozilla-Actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad  # v0.0.9
         with:
-          version: v0.10.0
+          version: v0.12.0
       - name: Environment Information
         run: npx envinfo
       - name: Download tarball
-        uses: actions/download-artifact@95815c38cf2ff2164869cbab79da8d1f422bc89e  # v4.2.1
+        uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53  # v6.0.0
         with:
           name: tarballs
           path: tarballs
       - name: Extract tarball
         run: |
-          tar xzf tarballs/*.tar.gz -C $RUNNER_TEMP
-          echo "TAR_DIR=$RUNNER_TEMP/`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
-      - name: Copy directories needed for testing
-        run: |
-          cp -r tools/eslint $TAR_DIR/tools
-          cp -r tools/eslint-rules $TAR_DIR/tools
+          tar xzf tarballs/*.tar.gz -C "$RUNNER_TEMP"
+          echo "TAR_DIR=$RUNNER_TEMP/$(basename tarballs/*.tar.gz .tar.gz)" >> "$GITHUB_ENV"
       - name: Build
-        run: |
-          cd $TAR_DIR
-          make build-ci -j4 V=1
+        run: make -C "$TAR_DIR" build-ci -j4 V=1
       - name: Test
-        run: |
-          cd $TAR_DIR
-          make run-ci -j4 V=1 TEST_CI_ARGS="-p dots  --measure-flakiness 9"
+        run: make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"

.github/workflows/build-tarball.yml

@@ -41,7 +41,7 @@ jobs:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639  # v9.1.0
+      - uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008  # v10.1.0
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           days-before-stale: 180

.github/workflows/close-stale-feature-requests.yml

@@ -20,7 +20,7 @@ jobs:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639  # v9.1.0
+      - uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008  # v10.1.0
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           days-before-close: 30