Skip to content

Commit 9813a93

Browse files
committed
Update method name in groupby to camel case
1 parent ee93342 commit 9813a93

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/danfojs-base/aggregators/groupby.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -462,31 +462,31 @@ export default class Groupby {
462462
* @returns DataFrame
463463
*
464464
*/
465-
cumsum(): DataFrame{
465+
cumSum(): DataFrame{
466466
return this.operations("cumsum")
467467
}
468468

469469
/**
470470
* Obtain the cummax of columns for each group
471471
* @returns DataFrame
472472
*/
473-
cummax(): DataFrame{
473+
cumMax(): DataFrame{
474474
return this.operations("cummax")
475475
}
476476

477477
/**
478478
* Obtain the cumprod of columns for each group
479479
* @returns DataFrame
480480
*/
481-
cumprod(): DataFrame{
481+
cumProd(): DataFrame{
482482
return this.operations("cumprod")
483483
}
484484

485485
/**
486486
* Obtain the cummin of columns for each group
487487
* @returns DataFrame
488488
*/
489-
cummin(): DataFrame{
489+
cumMin(): DataFrame{
490490
return this.operations("cummin")
491491
}
492492

src/danfojs-browser/tests/aggregators/groupby.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ describe("groupby", function () {
128128
[ 20, 30, 30, 40 ],
129129
[ 39, 89, 89, 78 ]
130130
];
131-
assert.deepEqual(group_df.col([ "B", "C" ]).cumsum().values, new_data);
131+
assert.deepEqual(group_df.col([ "B", "C" ]).cumSum().values, new_data);
132132
});
133133

134134
it("cummulative max for groupby", function () {
@@ -140,7 +140,7 @@ describe("groupby", function () {
140140
let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
141141

142142

143-
assert.deepEqual(group_df.col([ "C" ]).cummax().values, new_data);
143+
assert.deepEqual(group_df.col([ "C" ]).cumMax().values, new_data);
144144
});
145145

146146
it("cummulative min for groupby", function () {
@@ -151,7 +151,7 @@ describe("groupby", function () {
151151
let group_df = df.groupby([ "A" ]);
152152
let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
153153

154-
assert.deepEqual(group_df.col([ "C" ]).cummin().values, new_data);
154+
assert.deepEqual(group_df.col([ "C" ]).cumMin().values, new_data);
155155
});
156156

157157
it("cummulative prod for groupby", function () {
@@ -162,7 +162,7 @@ describe("groupby", function () {
162162
let group_df = df.groupby([ "A" ]);
163163
let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
164164

165-
assert.deepEqual(group_df.col([ "C" ]).cumprod().values, new_data);
165+
assert.deepEqual(group_df.col([ "C" ]).cumProd().values, new_data);
166166
});
167167

168168
it("mean for groupby", function () {

src/danfojs-node/test/aggregators/groupby.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ describe("groupby", function () {
131131
[20, 30, 30, 40],
132132
[39, 89, 89, 78]
133133
];
134-
assert.deepEqual(group_df.col(["B", "C"]).cumsum().values, new_data);
134+
assert.deepEqual(group_df.col(["B", "C"]).cumSum().values, new_data);
135135
});
136136

137137
it("cummulative max for groupby", function () {
@@ -143,7 +143,7 @@ describe("groupby", function () {
143143
let new_data = [[1, 3], [4, 6], [20, 40], [39, 78]];
144144

145145

146-
assert.deepEqual(group_df.col(["C"]).cummax().values, new_data);
146+
assert.deepEqual(group_df.col(["C"]).cumMax().values, new_data);
147147
});
148148

149149
it("cummulative min for groupby", function () {
@@ -154,7 +154,7 @@ describe("groupby", function () {
154154
let group_df = df.groupby(["A"]);
155155
let new_data = [[1, 3], [4, 6], [20, 40], [39, 78]];
156156

157-
assert.deepEqual(group_df.col(["C"]).cummin().values, new_data);
157+
assert.deepEqual(group_df.col(["C"]).cumMin().values, new_data);
158158
});
159159

160160
it("cummulative prod for groupby", function () {
@@ -165,7 +165,7 @@ describe("groupby", function () {
165165
let group_df = df.groupby(["A"]);
166166
let new_data = [[1, 3], [4, 6], [20, 40], [39, 78]];
167167

168-
assert.deepEqual(group_df.col(["C"]).cumprod().values, new_data);
168+
assert.deepEqual(group_df.col(["C"]).cumProd().values, new_data);
169169
});
170170

171171
it("mean for groupby", function () {

0 commit comments

Comments
 (0)