Fixed subsetting bug after rename

Author: risenW

danfojs-browser/src/core/frame.js

@@ -2043,8 +2043,10 @@ export default class DataFrame extends NDframe {
     }
 
     if (axis === 1) {
+      const colsAdded = [];
       const newColumns = this.columns.map((col) => {
         if (mapper[col] !== undefined) {
+          colsAdded.push(mapper[col]);
           return mapper[col];
         } else {
           return col;
@@ -2053,6 +2055,9 @@ export default class DataFrame extends NDframe {
 
       if (inplace) {
         this.$setColumnNames(newColumns);
+        for (const col of colsAdded) {
+          this.$setInternalColumnDataProperty(col);
+        }
       } else {
         return new DataFrame([...this.values], {
           index: [...this.index],

danfojs-browser/tests/core/frame.js

@@ -2020,6 +2020,29 @@ describe("DataFrame", function () {
       assert.deepEqual(df.index, res);
 
     });
+
+    it("Get new column via subseting works after rename (inplace)", function () {
+      let data = {
+        "A": [-20, 30, 47.3],
+        "B": [34, -4, 5],
+        "C": [20, 2, 30]
+      };
+      let df = new dfd.DataFrame(data);
+      df.rename({ mapper: { "A": "new_name" }, inplace: true });
+      df["new_name"].print();
+      assert.deepEqual(df["new_name"].values, data["A"]);
+    });
+
+    it("Get new column via subseting works after rename (not-inplace)", function () {
+      let data = {
+        "A": [-20, 30, 47.3],
+        "B": [34, -4, 5],
+        "C": [20, 2, 30]
+      };
+      let df = new dfd.DataFrame(data);
+      let new_df = df.rename({ mapper: { "A": "new_name" } });
+      assert.deepEqual(new_df["new_name"].values, data["A"]);
+    });
   });
 
   describe("sort_index", function () {

danfojs-node/src/core/frame.js

@@ -2045,8 +2045,10 @@ export default class DataFrame extends NDframe {
     }
 
     if (axis === 1) {
+      const colsAdded = [];
       const newColumns = this.columns.map((col) => {
         if (mapper[col] !== undefined) {
+          colsAdded.push(mapper[col]);
           return mapper[col];
         } else {
           return col;
@@ -2055,6 +2057,9 @@ export default class DataFrame extends NDframe {
 
       if (inplace) {
         this.$setColumnNames(newColumns);
+        for (const col of colsAdded) {
+          this.$setInternalColumnDataProperty(col);
+        }
       } else {
         return new DataFrame([...this.values], {
           index: [...this.index],

danfojs-node/tests/core/frame.js

@@ -2052,6 +2052,28 @@ describe("DataFrame", function () {
       assert.deepEqual(df.index, res);
 
     });
+    it("Get new column via subseting works after rename (inplace)", function () {
+      let data = {
+        "A": [-20, 30, 47.3],
+        "B": [34, -4, 5],
+        "C": [20, 2, 30]
+      };
+      let df = new DataFrame(data);
+      df.rename({ mapper: { "A": "new_name" }, inplace: true });
+      df["new_name"].print();
+      assert.deepEqual(df["new_name"].values, data["A"]);
+    });
+
+    it("Get new column via subseting works after rename (not-inplace)", function () {
+      let data = {
+        "A": [-20, 30, 47.3],
+        "B": [34, -4, 5],
+        "C": [20, 2, 30]
+      };
+      let df = new DataFrame(data);
+      let new_df = df.rename({ mapper: { "A": "new_name" } });
+      assert.deepEqual(new_df["new_name"].values, data["A"]);
+    });
   });
 
   describe("sort_index", function () {