Skip to content

Commit ee274d3

Browse files
committed
[get_dummies][s]: fix bug base on #274
1 parent 838cb5a commit ee274d3

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

danfojs-browser/src/core/get_dummies.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function get_dummy(kwargs = {}) {
7777
} else {
7878

7979
columns.forEach((x) => {
80-
let col_idx = columns.indexOf(x);
80+
let col_idx = in_data.columns.indexOf(x);
8181
column_index.push(col_idx);
8282
});
8383
}

danfojs-node/dist/core/get_dummies.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ function get_dummy(kwargs = {}) {
7474
});
7575
} else {
7676
columns.forEach(x => {
77-
let col_idx = columns.indexOf(x);
77+
let col_idx = in_data.columns.indexOf(x);
7878
column_index.push(col_idx);
7979
});
8080
}

danfojs-node/src/core/get_dummies.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function get_dummy(kwargs = {}) {
7777
} else {
7878

7979
columns.forEach((x) => {
80-
let col_idx = columns.indexOf(x);
80+
let col_idx = in_data.columns.indexOf(x);
8181
column_index.push(col_idx);
8282
});
8383
}

danfojs-node/tests/core/get_dummies.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,20 @@ describe("get_dummies", function(){
149149
"prefix for dataframe must be an array");
150150

151151
});
152+
it("should one hot encode all other columns", function(){
153+
154+
let data = [ [ 1, "dog", 1.0, "fat" ], [ 3, "fog", 2.0, "good" ], [ 4, "gof", 3.0, "best" ] ];
155+
let columns = [ "A", "B", "C", "d" ];
156+
let df = new DataFrame(data, { columns:columns });
157+
let rslt = [
158+
[ 1, 'dog', 1, 1, 0, 0 ],
159+
[ 3, 'fog', 2, 0, 1, 0 ],
160+
[ 4, 'gof', 3, 0, 0, 1 ]
161+
]
162+
163+
assert.deepEqual(get_dummies({ data:df, columns:[ "d" ]}).values, rslt)
164+
165+
});
152166

153167

154168
});

0 commit comments

Comments
 (0)