Fix regression in isObject (crashed w/ null values).

halflings · halflings · commit fcd7701fcdbd · 2021-12-26T12:46:04.000+01:00
diff --git a/danfojs-browser/src/shared/utils.js b/danfojs-browser/src/shared/utils.js
@@ -63,7 +63,7 @@ class Utils {
      * @returns
      */
   isObject(value) {
-    return typeof value === "object" && value.constructor && value.constructor.name === "Object";
+    return value && typeof value === "object" && value.constructor && value.constructor.name === "Object";
   }
 
   /**
diff --git a/danfojs-node/src/shared/utils.js b/danfojs-node/src/shared/utils.js
@@ -63,7 +63,7 @@ class Utils {
      * @returns
      */
   isObject(value) {
-    return typeof value === "object" && value.constructor && value.constructor.name === "Object";
+    return value && typeof value === "object" && value.constructor && value.constructor.name === "Object";
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ class Utils {`
`63`	`63`	`* @returns`
`64`	`64`	`*/`
`65`	`65`	`isObject(value) {`
`66`		`- return typeof value === "object" && value.constructor && value.constructor.name === "Object";`
	`66`	`+ return value && typeof value === "object" && value.constructor && value.constructor.name === "Object";`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`/**`