Skip to content

Support for MSVC compiler #15

@breitlauch

Description

@breitlauch

Hello again,
the following is already solved and therefore just for your information - maybe you want to include these information in one of your next commits. :)

I registered two pretty small errors while compiling the xosc.h-file with MSVC2017 64 bit.

  1. At line 138:
    enum class e_ReferenceContext : std::uint8_t
    {
    ABSOLUTE, //absolute
    RELATIVE //relative
    };
    The enumerations ABSOLUTE and RELATIVE seems to be already defined in MSVC. After changing them to ABSOLUTE_ and RELATIVE_ the error was solved.

  2. At line 3054:
    struct Polyline
    {
    /**/
    public:
    Polyline(){};
    Polyline(pugi::xml_node node);
    void save(pugi::xml_node node);
    virtual ~Polyline(){};
    public:
    std::vector<std::shared_ptr<Vertex>> m_Vertexs; //xs:element
    };
    The class name Polyline is already defined as a function in wingdi.h (Windows). I assume, that this is also linked to the MSCV compiler. I changed Polyline to Polyline_ and compiled without error.

Of course I also changed every occurrence of the changed enumerations and the Polyline class.

Again, thank you for your very useful library!
Stay healthy

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions