bug EasyCorp#7477 Fix route generation for entities called Controller (javiereguiluz)

This PR was squashed before being merged into the 4.x branch.

Discussion
----------

Fix route generation for entities called Controller

Fixes EasyCorp#7167.

Commits
-------

9b0d71b Fix route generation for entities called Controller

Author: javiereguiluz

src/Router/AdminRouteGenerator.php

@@ -882,7 +882,7 @@ private function getPhpAttributeInstance(string $classFqcn, string $attributeFqc
      */
     private function transformCrudControllerNameToKebabCase(string $crudControllerFqcn): string
     {
-        $cleanShortName = str_replace(['CrudController', 'Controller'], '', (new \ReflectionClass($crudControllerFqcn))->getShortName());
+        $cleanShortName = preg_replace('/(?:Crud)?Controller$/', '', (new \ReflectionClass($crudControllerFqcn))->getShortName());
         $snakeCaseName = strtolower(preg_replace('/(?<!^)[A-Z]/', '-$0', $cleanShortName));
 
         return $snakeCaseName;
@@ -895,7 +895,7 @@ private function transformCrudControllerNameToKebabCase(string $crudControllerFq
      */
     private function transformCrudControllerNameToSnakeCase(string $crudControllerFqcn): string
     {
-        $shortName = str_replace(['CrudController', 'Controller'], '', (new \ReflectionClass($crudControllerFqcn))->getShortName());
+        $shortName = preg_replace('/(?:Crud)?Controller$/', '', (new \ReflectionClass($crudControllerFqcn))->getShortName());
 
         return strtolower(preg_replace('/(?<!^)[A-Z]/', '_$0', $shortName));
     }

tests/Functional/AdminRoute/AdminRouteTest.php

@@ -612,6 +612,26 @@ public function testLegacyLinkToCrudMenuItemStillWorks(): void
         $this->assertInstanceOf(CrudMenuItem::class, $menuItem);
     }
 
+    public function testCrudControllerNamedController(): void
+    {
+        $client = static::createClient();
+        $router = $client->getContainer()->get('router');
+
+        // test that ControllerCrudController generates routes with "controller" as the path segment
+        // (this was previously broken because str_replace removed "Controller" from the middle of the name)
+        $indexRoute = $router->getRouteCollection()->get('admin_controller_index');
+        $this->assertNotNull($indexRoute, 'Route "admin_controller_index" should exist');
+        $this->assertSame('/admin/controller', $indexRoute->getPath());
+
+        $detailRoute = $router->getRouteCollection()->get('admin_controller_detail');
+        $this->assertNotNull($detailRoute, 'Route "admin_controller_detail" should exist');
+        $this->assertSame('/admin/controller/{entityId}', $detailRoute->getPath());
+
+        // test that routes also exist for the second dashboard
+        $this->assertNotNull($router->getRouteCollection()->get('second_admin_controller_index'));
+        $this->assertNotNull($router->getRouteCollection()->get('second_admin_controller_detail'));
+    }
+
     public function testAdminDashboardAdvancedRouteOptions(): void
     {
         $client = static::createClient();

tests/Functional/Apps/AdminRouteApp/src/Controller/ControllerCrudController.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace EasyCorp\Bundle\EasyAdminBundle\Tests\Functional\Apps\AdminRouteApp\Controller;
+
+use EasyCorp\Bundle\EasyAdminBundle\Controller\AbstractCrudController;
+use EasyCorp\Bundle\EasyAdminBundle\Tests\Functional\Apps\AdminRouteApp\Entity\Product;
+
+/**
+ * Test CRUD controller whose class name triggers the suffix stripping bug
+ * reported in https://github.com/EasyCorp/EasyAdminBundle/issues/7167.
+ * The entity name "Controller" causes the auto-generated route to be empty
+ * when using str_replace instead of suffix-only stripping.
+ */
+class ControllerCrudController extends AbstractCrudController
+{
+    public static function getEntityFqcn(): string
+    {
+        return Product::class;
+    }
+}