Rework tests after changes around package_info endpoint

Author: javihernandez

tests/conftest.py

@@ -6,8 +6,9 @@
     "tests.fixtures.database",
     "tests.fixtures.dramatiq",
     "tests.fixtures.errata",
-    'tests.fixtures.limiter',
+    "tests.fixtures.limiter",
     "tests.fixtures.modularity",
+    "tests.fixtures.package_info",
     "tests.fixtures.platforms",
     "tests.fixtures.products",
     "tests.fixtures.pulp",

tests/fixtures/package_info.py

@@ -0,0 +1,52 @@
+from typing import List, Dict, Any
+
+import pytest
+
+from alws.errors import PlatformNotFoundError, RepositoriesNotFoundError 
+
+@pytest.fixture
+def package_info() -> List[Dict[str, Any]]:
+    return [
+        {
+            "name": "example_package",
+            "version": "1.0",
+            "release": "1.el8",
+            "changelogs": ["Initial release"],
+        },
+        {
+            "name": "example_package",
+            "version": "1.1",
+            "release": "2.el9",
+            "changelogs": ["Bug fixes"],
+        },
+    ]
+
+
+@pytest.fixture
+def mock_get_package_info_success(monkeypatch, package_info):
+    async def mock_func(*args, **kwargs):
+        return package_info
+    monkeypatch.setattr("alws.crud.package_info.get_package_info", mock_func)
+
+
+@pytest.fixture
+def mock_get_package_info_platform_not_found(monkeypatch):
+    async def mock_func(*args, **kwargs):
+        raise PlatformNotFoundError("Invalid distribution: AlmaLinux-999")
+    monkeypatch.setattr("alws.crud.package_info.get_package_info", mock_func)
+
+
+@pytest.fixture
+def mock_get_package_info_repos_not_found(monkeypatch):
+    async def mock_func(*args, **kwargs):
+        raise RepositoriesNotFoundError("No repositories found")
+    monkeypatch.setattr("alws.crud.package_info.get_package_info", mock_func)
+
+
+@pytest.fixture
+def mock_get_package_info_empty(monkeypatch):
+    async def mock_func(*args, **kwargs):
+        return []
+    monkeypatch.setattr("alws.crud.package_info.get_package_info", mock_func)
+
+

tests/fixtures/pulp.py

@@ -483,41 +483,6 @@ async def func(*args, **kwargs):
     monkeypatch.setattr("alws.crud.build_node.get_module_from_pulp_db", func)
 
 
-@pytest.fixture
-def package_info() -> List[Dict[str, Any]]:
-    return [
-        {
-            "name": "example_package",
-            "version": "example_version",
-            "release": "example_release.el8",
-            "arch": "example_arch",
-            "changelogs": ["example_changelogs"],
-        },
-        {
-            "name": "example_package",
-            "version": "example_version_2",
-            "release": "example_release_2.el9",
-            "arch": "example_arch_2",
-            "changelogs": ["example_changelogs_2"],
-        },
-    ]
-
-
-@pytest.fixture
-def get_rpm_packages(monkeypatch, package_info):
-    async def func(*args, **kwargs):
-        res = []
-        for package in package_info:
-            if "name" in kwargs and package["name"] != kwargs["name"]:
-                continue
-            if "include_fields" in kwargs:
-                package = {field: package[field] for field in kwargs["include_fields"]}
-            res.append(package)
-        return res
-
-    monkeypatch.setattr(PulpClient, "get_rpm_packages", func)
-
-
 @pytest.fixture
 def get_removed_rpm_packages_from_latest_repo_version(monkeypatch):
     def func(*args, **kwargs):

tests/test_api/test_package_info.py

@@ -1,57 +1,57 @@
 import pytest
 
+from fastapi import status
+
 from alws.app import app
 from tests.mock_classes import BaseAsyncTestCase
 
 
 @pytest.mark.usefixtures(
-    "get_rpm_packages",
     "patch_limiter"
 )
 class TestPackageInfoEndpoints(BaseAsyncTestCase):
-    async def test_get_package_info(self):
+    async def test_get_package_info_success(self, mock_get_package_info_success, package_info):
         response = await self.make_request(
             "get",
-            "/api/v1/package_info/?package_name=example_package",
+            "/api/v1/package_info/?name=example_package&almalinux_version=9",
         )
-        assert (
-            response.status_code == self.status_codes.HTTP_200_OK
-            and response.json()
-        ), f"Cannot get package info by package name:\n{response.text}"
 
-    async def test_get_package_info_version(self):
-        version = 9
-        not_version = 5
+        assert response.status_code == status.HTTP_200_OK
+        data = response.json()
+        assert data == package_info
 
+    async def test_platform_not_found(self, mock_get_package_info_platform_not_found):
         response = await self.make_request(
             "get",
-            f"/api/v1/package_info/?package_name=example_package&release_version={version}",
+            "/api/v1/package_info/?name=bash&almalinux_version=999",
         )
-        response_json = response.json()
-        assert (
-            response.status_code == self.status_codes.HTTP_200_OK
-            and response_json
-        ), f"Cannot get package info by package name and major version:\n{response.text}"
-        assert (
-            response_json[0]["release"]
-            and f"el9" in response_json[0]["release"]
+
+        assert response.status_code == status.HTTP_400_BAD_REQUEST
+        assert "Invalid distribution" in response.text
+
+    async def test_repositories_not_found(self, mock_get_package_info_repos_not_found):
+        response = await self.make_request(
+            "get",
+            "/api/v1/package_info/?name=bash&almalinux_version=9&arch=x86_64",
         )
 
+        assert response.status_code == status.HTTP_400_BAD_REQUEST
+        assert "No repositories found" in response.text
+
+
+    async def test_empty_package_list(self, mock_get_package_info_empty):
         response = await self.make_request(
             "get",
-            f"/api/v1/package_info/?package_name=example_package&release_version={not_version}",
+            "/api/v1/package_info/?name=none&almalinux_version=9",
         )
-        assert (
-            response.status_code == self.status_codes.HTTP_200_OK
-            and not response.json()
-        ), f"Cannot get package info by package name and major version:\n{response.text}"
 
-    async def test_get_no_package_info(self):
+        assert response.status_code == status.HTTP_200_OK
+        assert response.json() == []
+
+    async def test_missing_required_query_params(self):
         response = await self.make_request(
             "get",
-            "/api/v1/package_info/?package_name=doesnt_exist",
+            "/api/v1/package_info/?name=bash",
         )
-        assert (
-            response.status_code == self.status_codes.HTTP_200_OK
-            and not response.json()
-        ), f"Error in fetching missing package:\n{response.text}"
+
+        assert response.status_code == status.HTTP_422_UNPROCESSABLE_ENTITY