Skip to content

Commit 70e06c2

Browse files
committed
Avoid adding conflicting --repo_env=HERMETIC_PYTHON_VERSION= to bazel command
1 parent 7dd401c commit 70e06c2

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

build/build.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ def add_global_arguments(parser: argparse.ArgumentParser):
6969
parser.add_argument(
7070
"--python_version",
7171
type=str,
72-
choices=["3.10", "3.11", "3.12", "3.13"],
7372
default=f"{sys.version_info.major}.{sys.version_info.minor}",
7473
help=
7574
"""
@@ -381,6 +380,14 @@ async def main():
381380
bazel_command_base.append("run")
382381

383382
if args.python_version:
383+
# Do not add --repo_env=HERMETIC_PYTHON_VERSION with default args.python_version
384+
# if bazel_options override it
385+
python_version_opt = "--repo_env=HERMETIC_PYTHON_VERSION="
386+
if any([python_version_opt in opt for opt in args.bazel_options]):
387+
raise RuntimeError(
388+
"Please use python_version to set hermetic python version instead of "
389+
"setting --repo_env=HERMETIC_PYTHON_VERSION=<python version> bazel option"
390+
)
384391
logging.debug("Hermetic Python version: %s", args.python_version)
385392
bazel_command_base.append(
386393
f"--repo_env=HERMETIC_PYTHON_VERSION={args.python_version}"

0 commit comments

Comments
 (0)