Skip to content

Commit f9737b9

Browse files
tlongeriGoogle-ML-Automation
authored andcommitted
[Mosaic:TPU] Fix bug after cl/707025084
`tile_masks` was updated to use implicit, but we skipped the reshape for `tiles` Seems like there was even a bug before cl/707025084: `tile_masks` was never reshaped, so if the shape was 1D and a store mask was specified, there would be a mismatch in dimensions. PiperOrigin-RevId: 707368670
1 parent 09fdd0d commit f9737b9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

jaxlib/mosaic/dialect/tpu/transforms/apply_vector_layout.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4397,7 +4397,7 @@ LogicalResult vector_store_impl(RewriteContext &ctx, Op store_op,
43974397
FAILUREOR_ASSIGN_OR_RETURN(
43984398
xla::Array<Value> tiles,
43994399
disassemble(builder, to_store_layout, store_op.getValueToStore(),
4400-
ctx.target_shape));
4400+
ctx.target_shape, /*use_implicit_shape=*/true));
44014401
std::optional<xla::Array<Value>> tile_masks;
44024402
if (store_mask) {
44034403
FAILUREOR_ASSIGN_OR_RETURN(

0 commit comments

Comments
 (0)