more bug fixes, add AGENTS.md, linter fixes. Add animation for frequency tuning

jaybaird · jaybaird · commit af9855e9baf8 · 2026-02-13T16:47:35.000-08:00
diff --git a/AGENTS.md b/AGENTS.md
@@ -33,6 +33,7 @@ Core features:
 - Build: `meson setup build && meson compile -C build`
 - Reconfigure: `meson setup build --reconfigure`
 - Translation template: `ninja -C build com.k0vcz.Artemis-pot`
+- Lint must pass before commit (same expectation as pre-commit hooks, including `vala-lint`).
 
 When changing UI/resources, ensure the build succeeds and generated resources remain valid.
 
diff --git a/README.md b/README.md
@@ -29,7 +29,7 @@ Artemis is designed to be cross-platform, lightweight, and easy to use.
   - Supports serial, USB, and network-connected radios via Hamlib.
 
 - **Import/Export**
-  - Import your already hunted parks from (POTA.app)[https://pota.app]
+  - Import your already hunted parks from [POTA.app](https://pota.app)
   - Ability to exporting hunter QSOs to QRZ; LoTW, UDP, or local ADIF log coming soon.
 
 - **UI**
diff --git a/src/map_view.vala b/src/map_view.vala
@@ -287,12 +287,12 @@ public class MapView : Gtk.Box {
             if (now.compare (expires) > 0)
                 return false;
 
-            if ((Application.current_program_filter != null) && 
+            if ((Application.current_program_filter != null) &&
                 (Application.current_program_filter != _ ("All")) &&
                 !spot.park_ref.down ().has_prefix (Application.current_program_filter.down ()))
                 return false;
 
-            if ((Application.current_mode_filter != null) && 
+            if ((Application.current_mode_filter != null) &&
                 (Application.current_mode_filter != _ ("All")) &&
                 !spot.mode.down ().contains (Application.current_mode_filter.down ()))
                 return false;
@@ -372,10 +372,10 @@ public class MapView : Gtk.Box {
         click.pressed.connect (() => {
             marker_clicked = true;
             Application.current_spot_hash = spot.hash;
-        
+
             var sidebar_box = split_view.sidebar as Gtk.Box;
             var spot_card = new SpotCard.from_spot (spot);
-            
+
             for (var child = sidebar_box.get_first_child (); child != null;) {
                 sidebar_box.remove (child);
                 child = child.get_next_sibling ();
@@ -429,7 +429,7 @@ public class MapView : Gtk.Box {
 
         map_widget.insert_layer_above (marker_layer, map_layer);
 
-        if (Application.current_spot_hash == BLANK_HASH || 
+        if (Application.current_spot_hash == BLANK_HASH ||
             !valid_hashes.contains (Application.current_spot_hash)) {
             if (split_view.show_sidebar) {
                 split_view.show_sidebar = false;
diff --git a/src/repo.vala b/src/repo.vala
@@ -15,6 +15,7 @@ public class CallsignCacheEntry : Object {
 
 public class CallsignCache : Object {
     private HashTable<string, CallsignCacheEntry> ham_cache;
+    private HashSet<string> avatar_fetch_inflight;
     private Soup.Session avatar_session;
     public uint ttl_seconds { get; construct; default = 3600; }
 
@@ -34,13 +35,14 @@ public class CallsignCache : Object {
     construct {
         ham_cache = new HashTable<string, CallsignCacheEntry> (GLib.str_hash,
             GLib.str_equal);
+        avatar_fetch_inflight = new HashSet<string> ();
         avatar_session = new Soup.Session ();
         var cache_dir = Path.build_filename (Environment.get_user_cache_dir (),
             "artemis");
         var cache = new Soup.Cache (cache_dir, Soup.CacheType.SINGLE_USER);
         cache.set_max_size (50 * 1024 * 1024);
         avatar_session.add_feature (cache);
-        avatar_session.timeout = 10;
+        avatar_session.timeout = 3;
         avatar_session.user_agent = "Artemis/0.1.0";
     }
 
@@ -52,6 +54,7 @@ public class CallsignCache : Object {
 
     public void clear () {
         ham_cache.remove_all ();
+        avatar_fetch_inflight.clear ();
     }
 
     public async void load_callsigns (HashSet<string> callsigns) {
@@ -70,29 +73,34 @@ public class CallsignCache : Object {
         if ((cached_entry != null) && (cached_entry.avatar != null))
             return cached_entry.avatar;
 
+        if (avatar_fetch_inflight.contains (callsign))
+            return null;
+
+        avatar_fetch_inflight.add (callsign);
+        Gdk.Texture? avatar = null;
         try {
             var gravatar_hash = entry.gravatar_hash;
-            if ((gravatar_hash == null) || (gravatar_hash.strip () == ""))
-                return null;
-
-            var url = "https://www.gravatar.com/avatar/%s?s=128&d=identicon"
-                .printf (gravatar_hash);
+            if ((gravatar_hash != null) && (gravatar_hash.strip () != "")) {
+                var url = "https://www.gravatar.com/avatar/%s?s=128&d=identicon"
+                    .printf (gravatar_hash);
 
-            var message = new Soup.Message ("GET", url);
+                var message = new Soup.Message ("GET", url);
 
-            var stream = yield avatar_session.send_async (message, GLib.Priority.
-                DEFAULT, null);
+                var stream = yield avatar_session.send_async (message, GLib.Priority.
+                    DEFAULT, null);
 
-            var pixbuf = new Gdk.Pixbuf.from_stream (stream);
-            if (pixbuf != null) {
-                var texture = Gdk.Texture.for_pixbuf (pixbuf);
-                cached_entry.avatar = texture;
-                return texture;
+                var pixbuf = new Gdk.Pixbuf.from_stream (stream);
+                if (pixbuf != null) {
+                    var texture = Gdk.Texture.for_pixbuf (pixbuf);
+                    cached_entry.avatar = texture;
+                    avatar = texture;
+                }
             }
         } catch (Error e) {
             warning ("Failed to fetch avatar for %s: %s", callsign, e.message);
         }
-        return null;
+        avatar_fetch_inflight.remove (callsign);
+        return avatar;
     }
 
     public async Activator? get_callsign (string callsign) {
diff --git a/src/window.vala b/src/window.vala
@@ -72,12 +72,18 @@ public sealed class AppWindow : Gtk.Window {
 
     private uint timer_id = 0;
     private uint progress_timer_id = 0;
+    private uint radio_vfo_anim_id = 0;
     private int64 last_refresh_time = 0;
+    private int64 radio_vfo_anim_started_at = 0;
 
     private uint current_ticks = 0;
     private bool update_paused = false;
     private ArrayList<Adw.ViewStackPage> band_pages;
     private MapView map_view;
+    private bool has_displayed_radio_vfo = false;
+    private int displayed_radio_vfo_khz = 0;
+    private int radio_vfo_anim_start_khz = 0;
+    private int radio_vfo_anim_target_khz = 0;
 
     private ulong program_select_handler = 0;
 
@@ -118,7 +124,7 @@ public sealed class AppWindow : Gtk.Window {
         search_entry.search_changed.connect (() => {
             Application.current_search_text = search_entry.text;
 
-            map_view.bounce_filter ();
+            bounce_map_filter_if_ready ();
             foreach (var page in band_pages) {
                 var band_view = page.get_child () as BandView;
                 band_view.bounce_filter ();
@@ -140,7 +146,7 @@ public sealed class AppWindow : Gtk.Window {
 
                 Application.current_mode_filter = mode;
 
-                map_view.bounce_filter ();
+                bounce_map_filter_if_ready ();
 
                 foreach (var page in band_pages) {
                     var band_view = page.get_child () as BandView;
@@ -156,7 +162,10 @@ public sealed class AppWindow : Gtk.Window {
 
         Application.spot_repo.busy_changed.connect ((busy) => {
             loading_spinner.visible = busy;
-            program_select.disconnect (program_select_handler);
+            if (busy && (program_select_handler != 0)) {
+                program_select.disconnect (program_select_handler);
+                program_select_handler = 0;
+            }
         });
 
         Application.spot_repo.refreshed.connect ((spots_updated) => {
@@ -179,8 +188,10 @@ public sealed class AppWindow : Gtk.Window {
                 }
             }
             program_select.set_selected (idx);
-            program_select_handler = program_select.notify["selected"].connect (
-                on_program_selected);
+            if (program_select_handler == 0) {
+                program_select_handler = program_select.notify["selected"].connect (
+                    on_program_selected);
+            }
 
             last_refresh_time = get_monotonic_time ();
             current_ticks = 0;
@@ -228,7 +239,7 @@ public sealed class AppWindow : Gtk.Window {
         band_stack.notify["visible-child-name"].connect (() => {
             Application.current_band_filter = band_stack.visible_child_name;
             update_status_bar ();
-            map_view.bounce_filter ();
+            bounce_map_filter_if_ready ();
         });
 
         var model = search_select.get_model () as Gtk.StringList;
@@ -292,11 +303,16 @@ public sealed class AppWindow : Gtk.Window {
             (uint)total_visible
         ).printf ((uint)total_visible);
 
-        var status_bar_filtered_text = "; %u filtered".printf ((uint)filtered_count);
+        var status_bar_filtered_text = " • %u filtered".printf ((uint)filtered_count);
 
         status_bar_text.label = "%s%s".printf (status_bar_spots_text, status_bar_filtered_text);
     }
 
+    private void bounce_map_filter_if_ready () {
+        if (map_view != null)
+            map_view.bounce_filter ();
+    }
+
     private void initial_update () {
         Application.spot_repo.update_spots.begin ((obj, res) => {
             Application.spot_repo.update_spots.end (res);
@@ -337,8 +353,60 @@ public sealed class AppWindow : Gtk.Window {
         }
     }
 
+    private void stop_radio_vfo_animation () {
+        if (radio_vfo_anim_id != 0) {
+            Source.remove (radio_vfo_anim_id);
+            radio_vfo_anim_id = 0;
+        }
+    }
+
+    private void set_radio_vfo_label_animated (int freq_khz) {
+        if (!has_displayed_radio_vfo) {
+            displayed_radio_vfo_khz = freq_khz;
+            has_displayed_radio_vfo = true;
+            radio_vfo.label = format_vfo (freq_khz);
+            return;
+        }
+
+        stop_radio_vfo_animation ();
+
+        radio_vfo_anim_start_khz = displayed_radio_vfo_khz;
+        radio_vfo_anim_target_khz = freq_khz;
+        if (radio_vfo_anim_start_khz == radio_vfo_anim_target_khz) {
+            radio_vfo.label = format_vfo (freq_khz);
+            return;
+        }
+
+        radio_vfo_anim_started_at = get_monotonic_time ();
+        radio_vfo_anim_id = Timeout.add (16, () => {
+            const double DURATION_MS = 160.0;
+            var elapsed_ms = (get_monotonic_time () - radio_vfo_anim_started_at) / 1000.0;
+            var t = elapsed_ms / DURATION_MS;
+            if (t > 1.0)
+                t = 1.0;
+
+            // Ease-out interpolation so the value settles smoothly.
+            var eased_t = 1.0 - ((1.0 - t) * (1.0 - t));
+            var interpolated = (double)radio_vfo_anim_start_khz +
+                ((double)(radio_vfo_anim_target_khz - radio_vfo_anim_start_khz) * eased_t);
+            displayed_radio_vfo_khz = (int)Math.round (interpolated);
+            radio_vfo.label = format_vfo (displayed_radio_vfo_khz);
+
+            if (t >= 1.0) {
+                displayed_radio_vfo_khz = radio_vfo_anim_target_khz;
+                radio_vfo.label = format_vfo (displayed_radio_vfo_khz);
+                radio_vfo_anim_id = 0;
+                return Source.REMOVE;
+            }
+
+            return Source.CONTINUE;
+        });
+    }
+
     private void power_off_radio () {
         Application.radio_control.disconnect ().disown ();
+        stop_radio_vfo_animation ();
+        has_displayed_radio_vfo = false;
         radio_vfo.label = _("Radio disconnected");
         radio_mode.visible = false;
     }
@@ -367,16 +435,20 @@ public sealed class AppWindow : Gtk.Window {
                     Application.radio_control.radio_status.connect ((freq, mode) => {
                         if (freq > 0 && mode != 0) {
                             radio_mode.visible = true;
-                            radio_vfo.label = format_vfo (freq);
+                            set_radio_vfo_label_animated (freq);
                             radio_mode.label = RadioControl.mode_string (mode);
                             radio_power_button.active = true;
                         } else {
+                            stop_radio_vfo_animation ();
+                            has_displayed_radio_vfo = false;
                             radio_mode.visible = false;
                             radio_power_button.active = false;
                             radio_vfo.label = _("Radio disconnected");
                         }
                     });
                 } else {
+                    stop_radio_vfo_animation ();
+                    has_displayed_radio_vfo = false;
                     radio_mode.visible = false;
                     radio_power_button.active = false;
                     radio_vfo.label = _("Radio disconnected");
@@ -473,7 +545,7 @@ public sealed class AppWindow : Gtk.Window {
 
             Application.current_program_filter = program;
 
-            map_view.bounce_filter ();
+            bounce_map_filter_if_ready ();
 
             foreach (var page in band_pages) {
                 var band_view = page.get_child () as BandView;
@@ -490,5 +562,7 @@ public sealed class AppWindow : Gtk.Window {
 
         if (progress_timer_id != 0)
             Source.remove (progress_timer_id);
+
+        stop_radio_vfo_animation ();
     }
 } /* class AppWindow */
