fix(compiler): fix potential bug in UpdateCompiler

jayvynl · jayvynl · commit 1a7f07ad14c9 · 2023-11-30T00:12:14.000+08:00
diff --git a/clickhouse_backend/models/sql/compiler.py b/clickhouse_backend/models/sql/compiler.py
@@ -201,7 +201,7 @@ def as_sql(self):
                     )
             elif hasattr(val, "prepare_database_save"):
                 if field.remote_field:
-                    val = field.get_db_prep_save(
+                    val = field.get_db_prep_value(
                         val.prepare_database_save(field),
                         connection=self.connection,
                     )
@@ -212,7 +212,8 @@ def as_sql(self):
                         % (field, val, field.__class__.__name__)
                     )
             else:
-                val = field.get_db_prep_save(val, connection=self.connection)
+                # update params are formatted into query string.
+                val = field.get_db_prep_value(val, connection=self.connection)
 
             # Getting the placeholder for the field.
             if hasattr(field, "get_placeholder"):

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ def as_sql(self):`
`201`	`201`	`)`
`202`	`202`	`elif hasattr(val, "prepare_database_save"):`
`203`	`203`	`if field.remote_field:`
`204`		`- val = field.get_db_prep_save(`
	`204`	`+ val = field.get_db_prep_value(`
`205`	`205`	`val.prepare_database_save(field),`
`206`	`206`	`connection=self.connection,`
`207`	`207`	`)`
`@@ -212,7 +212,8 @@ def as_sql(self):`
`212`	`212`	`% (field, val, field.__class__.__name__)`
`213`	`213`	`)`
`214`	`214`	`else:`
`215`		`- val = field.get_db_prep_save(val, connection=self.connection)`
	`215`	`+ # update params are formatted into query string.`
	`216`	`+ val = field.get_db_prep_value(val, connection=self.connection)`
`216`	`217`
`217`	`218`	`# Getting the placeholder for the field.`
`218`	`219`	`if hasattr(field, "get_placeholder"):`