Skip to content

Commit 4b066d4

Browse files
committed
test: fix test failures caused by enable DatabaseFeatures.supports_aggregate_filter_clause
1 parent c6be16d commit 4b066d4

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

tests/aggregation/test_filter_argument.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def test_related_aggregates_m2m_and_fk(self):
9292
def test_plain_annotate(self):
9393
agg = Sum("book__pages", filter=Q(book__rating__gt=3))
9494
qs = Author.objects.annotate(pages=agg).order_by("pk")
95-
self.assertSequenceEqual([a.pages for a in qs], [447, None, 1047])
95+
self.assertSequenceEqual([a.pages for a in qs], [447, 0, 1047])
9696

9797
def test_filtered_aggregate_on_annotate(self):
9898
pages_annotate = Sum("book__pages", filter=Q(book__rating__gt=3))

tests/aggregation/tests.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1537,6 +1537,7 @@ def test_aggregation_default_using_datetime_from_python(self):
15371537
expr = Min(
15381538
"store__original_opening",
15391539
filter=~Q(store__name="Amazon.com"),
1540+
# Never take effect
15401541
default=Cast(datetime.datetime(1970, 1, 1), DateTimeField()),
15411542
)
15421543
queryset = Book.objects.annotate(oldest_store_opening=expr).order_by("isbn")
@@ -1557,7 +1558,7 @@ def test_aggregation_default_using_datetime_from_python(self):
15571558
},
15581559
{
15591560
"isbn": "067232959",
1560-
"oldest_store_opening": datetime.datetime(1970, 1, 1),
1561+
"oldest_store_opening": datetime.datetime.fromtimestamp(0),
15611562
},
15621563
{
15631564
"isbn": "155860191",
@@ -1581,10 +1582,10 @@ def test_aggregation_default_using_datetime_from_python(self):
15811582
)
15821583

15831584
def test_aggregation_default_using_datetime_from_database(self):
1584-
now = timezone.now()
15851585
expr = Min(
15861586
"store__original_opening",
15871587
filter=~Q(store__name="Amazon.com"),
1588+
# Never take effect
15881589
default=TruncHour(NowUTC(), output_field=DateTimeField()),
15891590
)
15901591
queryset = Book.objects.annotate(oldest_store_opening=expr).order_by("isbn")
@@ -1605,9 +1606,7 @@ def test_aggregation_default_using_datetime_from_database(self):
16051606
},
16061607
{
16071608
"isbn": "067232959",
1608-
"oldest_store_opening": now.replace(
1609-
minute=0, second=0, microsecond=0, tzinfo=None
1610-
),
1609+
"oldest_store_opening": datetime.datetime.fromtimestamp(0),
16111610
},
16121611
{
16131612
"isbn": "155860191",

tests/clickhouse_table_engine/tests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from django.test import TestCase
33

44
from clickhouse_backend import models
5+
from clickhouse_backend.utils.timezone import get_timezone
56

67
from .models import EngineWithSettings, Event
78

@@ -16,7 +17,7 @@ def test_table(self):
1617
engine_full = cursor.fetchone()[0]
1718
self.assertEqual(
1819
engine_full.partition(" SETTINGS ")[0],
19-
"MergeTree PARTITION BY toYYYYMMDD(timestamp) PRIMARY KEY timestamp ORDER BY (timestamp, id)",
20+
f"MergeTree PARTITION BY toYYYYMMDD(timestamp, '{get_timezone()}') PRIMARY KEY timestamp ORDER BY (timestamp, id)",
2021
)
2122

2223
def test_mergetree_init_exception(self):

0 commit comments

Comments
 (0)