-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Topic is interesting and readme file presents the idea and status well. However, the app itself is still in quite of an early state and thus it is a bit difficult to rate the user experience. Here are some comments about the UI even if some of these features are probably on its way:
- When registering, the app does not request the user to repeat the password. If the user makes a typo, they will not know it.
- Landing page is directly the log in page that does not give any idea of the app that you are signing in to. Few words about the app could be added there.
- Home page (or all pages) is missing design. Home page could also have some text in addition to the links.
- Poll page could tell what is the scaling: what does 1 mean and is it worse or better than 5.
- Readme mentions a link to menstrual cycles but nothing in the app refers to that yet.
- In the readme file you mentioned the posibility to move from radio buttons to text fields. I actually prefer the radio buttons, since it is possible to draw a graph based on them. Maybe there could be an additional comment field (one per poll) that the user could then see, if they want to examine a specific day in the graph.
- The poll asks yesterday’s status and then it records the results on today’s date. If I would use the app, I would rather use it in the evening and rate current day’s status. In addition, I would like to have an option to update past date (with the selection of the date). Perhaps the poll could have selection of the date in the beginning that would be prefilled with today’s date (but there is an option to change it).
- Cancel option would be nice if the user enters to the poll but does not want to send it.
Comments about the code and database structure. There is yet only few lines of code so it is challenging to comment on the structure. In general, I found the code easy-to-follow.
- Perhaps, if there is more code in the future, it could make sense to keep all sql queries in users.py and db_queries.py and not in routes.py. Now there is sql in all of them. In addition, should db_queries be named for example poll.py? Is there a reason for db in the name when also users.py handles sql queries?
- This might be totally irrelevant but it took me a while to realize that you referred to tables Users and Questions in your table Data. You have that as alter table command rather than already in the Create table scripts (e.g. user_id INTEGER REFERENCES Users). Is there a reason for that?
- Could seed data (questions) and schema be separate files? The structure would be easier to read.
- In routes.py line 55 there is a print command that prints “Answers saved successfully” to the log but not to the user. Is this intentional? (Seems that there are more additional print commands probably still for testing reasons.
- It took me a while to understand that k refers to key and v to value in routes.py. This is probably due to my lack of experience but for me key and value would be easier to read.
- In routes.py there is unnecessary “else” in def user_data()
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels