Collapse not working in Django 5.2

[justmobilize]

It looks like with Django 5.2 this

              {% for fieldset in fieldsets %}
              <fieldset class="module{% if fieldset.collapse %} collapse{% endif %}">
                  <h2>{{ fieldset.title }}</h2>
                  {% with config_values=fieldset.config_values %}
                    {% include "admin/constance/includes/results_list.html" %}
                  {% endwith %}
              </fieldset>
              {% endfor %}

Should be updated to:

              {% for fieldset in fieldsets %}
              <fieldset class="module{% if fieldset.collapse %} collapse{% endif %}">
                  <details>
                      <summary>
                          <h2 class="fieldset-heading">{{ fieldset.title }}</h2>
                      <summary>
                      {% with config_values=fieldset.config_values %}
                        {% include "admin/constance/includes/results_list.html" %}
                      {% endwith %}
                  </details>
              </fieldset>
              {% endfor %}

Would you accept a PR for this?

Would put a % if django_version >= "5.2" %} wrapper and duplicate the section

[Natim]

Hello @justmobilize would you be so kind to create a PR implementing this change? Best regards 🙏

[justmobilize]

Here it is: #643!

[Natim]

The PR has been merged but tests need fixing before I can do a release.

[justmobilize]

@Natim I can fix these. Are you good with updating tests like so:

    @mock.patch(
        "constance.settings.CONFIG_FIELDSETS",
        {
            "Numbers": ("INT_VALUE",),
            "Text": ("STRING_VALUE",),
        },
    )
    def test_fieldset_headers(self):
        self.client.login(username="admin", password="nimda")
        request = self.rf.get("/admin/constance/config/")
        request.user = self.superuser
        response = self.options.changelist_view(request, {})
        if django.VERSION < (5,1):
            self.assertContains(response, "<h2>Numbers</h2>")
            self.assertContains(response, "<h2>Text</h2>")
        else:
            self.assertContains(response, '<h2 class="fieldset-heading">Numbers</h2>')
            self.assertContains(response, '<h2 class="fieldset-heading">Text</h2>')

or we could just do:

    @mock.patch(
        "constance.settings.CONFIG_FIELDSETS",
        {
            "Numbers": ("INT_VALUE",),
            "Text": ("STRING_VALUE",),
        },
    )
    def test_fieldset_headers(self):
        self.client.login(username="admin", password="nimda")
        request = self.rf.get("/admin/constance/config/")
        request.user = self.superuser
        response = self.options.changelist_view(request, {})
        self.assertContains(response, ">Numbers</h2>")
        self.assertContains(response, ">Text</h2>")

[Natim]

Yes or even:

        self.assertContains(response, "Numbers</h2>")
        self.assertContains(response, "Text</h2>")

[justmobilize]

Here it is: #646 - tests all pass