Skip to content

Commit 1df405e

Browse files
authored
Merge pull request #45 from stueken/master
Set on_delete attribute as required in Django 2.0
2 parents 60966c8 + ece6d6b commit 1df405e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

django_fsm_log/migrations/0001_initial.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ class Migration(migrations.Migration):
2222
('state', models.CharField(max_length=255, db_index=True)),
2323
('transition', models.CharField(max_length=255)),
2424
('object_id', models.PositiveIntegerField(db_index=True)),
25-
('by', models.ForeignKey(blank=True, to=settings.AUTH_USER_MODEL, null=True)),
26-
('content_type', models.ForeignKey(to='contenttypes.ContentType')),
25+
('by', models.ForeignKey(blank=True, to=settings.AUTH_USER_MODEL, null=True, on_delete=models.SET_NULL)),
26+
('content_type', models.ForeignKey(to='contenttypes.ContentType', on_delete=models.CASCADE)),
2727
],
2828
options={
2929
},

django_fsm_log/models.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,17 @@
2121
@python_2_unicode_compatible
2222
class StateLog(models.Model):
2323
timestamp = models.DateTimeField(default=now)
24-
by = models.ForeignKey(getattr(settings, 'AUTH_USER_MODEL', 'auth.User'), blank=True, null=True)
24+
by = models.ForeignKey(getattr(settings, 'AUTH_USER_MODEL', 'auth.User'), blank=True,
25+
null=True, on_delete=models.SET_NULL)
2526
state = models.CharField(max_length=255, db_index=True)
2627
transition = models.CharField(max_length=255)
2728

28-
content_type = models.ForeignKey(ContentType)
29+
content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE)
2930
object_id = models.PositiveIntegerField(db_index=True)
3031
content_object = GenericForeignKey('content_type', 'object_id')
3132

3233
objects = StateLogManager()
33-
34+
3435
class Meta:
3536
get_latest_by = 'timestamp'
3637

0 commit comments

Comments
 (0)