-
Notifications
You must be signed in to change notification settings - Fork 809
Fix: Handle AttributeError in IntrospectTokenView #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: Handle AttributeError in IntrospectTokenView #1562
Conversation
Contribution guideline says
but I do not have permission to set assignee. |
I'm not 100% sure this is the correct handling. Per https://datatracker.ietf.org/doc/html/rfc7662#section-2.3,
I'm not sure that a missing token would qualify as properly formed. I feel that a 400 might be the proper response in this case since the request is missing the required 'token' parameter. My instinct says a present, but invalid or blank token, i.e. a body of
would return an |
@dopry I agree with you. I've changed the response to follow https://datatracker.ietf.org/doc/html/rfc6749#section-5.2 |
8e17051
to
f321e0e
Compare
f321e0e
to
6416c38
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1562 +/- ##
=======================================
Coverage 97.37% 97.38%
=======================================
Files 34 34
Lines 2212 2214 +2
=======================================
+ Hits 2154 2156 +2
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
6416c38
to
f3c619b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
@dopry thanks for taking care of this |
Description of the Change
Handle
AttributeError
inget_token_response
. If there is notoken
parameter in introspect endpoints they raiseAttributeError
.Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS