Fix to shlex.split for *_(BINARY|ARGUMENTS) settings on windows

shlex.split(), without posix=False, strips "\" characters, which is
obviously problematic on windows.

Author: fdintino

pipeline/conf.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
+import os
 import collections
 import shlex
 
@@ -97,7 +98,7 @@ def __getitem__(self, key):
         value = self.settings[key]
         if key.endswith(("_BINARY", "_ARGUMENTS")):
             if isinstance(value, string_types):
-                return tuple(shlex.split(value))
+                return tuple(shlex.split(value, posix=(os.sep == '/')))
             return tuple(value)
         return value
 

tests/tests/test_conf.py

@@ -1,6 +1,9 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
+import sys
+from unittest import skipIf, skipUnless
+
 from django.test import TestCase
 
 from pipeline.conf import PipelineSettings
@@ -23,10 +26,16 @@ def test_expected_splitting(self):
         s = PipelineSettings({"FOO_BINARY": "env actualprogram"})
         self.assertEqual(s.FOO_BINARY, ('env', 'actualprogram'))
 
+    @skipIf(sys.platform.startswith("win"), "requires posix platform")
     def test_expected_preservation(self):
         s = PipelineSettings({"FOO_BINARY": r"actual\ program"})
         self.assertEqual(s.FOO_BINARY, ('actual program',))
 
+    @skipUnless(sys.platform.startswith("win"), "requires windows")
+    def test_win_path_preservation(self):
+        s = PipelineSettings({"FOO_BINARY": "C:\\Test\\ActualProgram.exe argument"})
+        self.assertEqual(s.FOO_BINARY, ('C:\\Test\\ActualProgram.exe', 'argument'))
+
     def test_tuples_are_normal(self):
         s = PipelineSettings({"FOO_ARGUMENTS": ("explicit", "with", "args")})
         self.assertEqual(s.FOO_ARGUMENTS, ('explicit', 'with', 'args'))