Fixed recursive call to django's staticfiles.finders.find() to prevent Exceptions on missing files with 3 extensions.

Author: Nathan Shafer

pipeline/finders.py

@@ -46,7 +46,10 @@ def find(self, path, all=False):
         try:
             start, _, extn = path.rsplit('.', 2)
             path = '.'.join((start, extn))
-            return find(path, all=all)
+            result = find(path, all=all)
+            if not result:
+                return []
+            return result
         except ValueError:
             return []
 

tests/tests/test_storage.py

@@ -1,5 +1,7 @@
 from __future__ import unicode_literals
 
+from django.conf import settings
+from django.contrib.staticfiles import finders
 from django.contrib.staticfiles.storage import staticfiles_storage
 from django.core.management import call_command
 from django.test import TestCase
@@ -69,3 +71,27 @@ def test_post_process_no_path(self):
                     call_command('collectstatic', verbosity=0, interactive=False)
                 except NotImplementedError:
                     self.fail('Received an error running collectstatic')
+
+    def test_nonexistent_file_pipeline_finder(self):
+        CUSTOM_FINDERS = settings.STATICFILES_FINDERS + ('pipeline.finders.PipelineFinder',)
+        with self.settings(STATICFILES_FINDERS=CUSTOM_FINDERS):
+            path = finders.find('nothing.css')
+            self.assertIsNone(path)
+
+    def test_nonexistent_file_cached_finder(self):
+        CUSTOM_FINDERS = settings.STATICFILES_FINDERS + ('pipeline.finders.CachedFileFinder',)
+        with self.settings(STATICFILES_FINDERS=CUSTOM_FINDERS):
+            path = finders.find('nothing.css')
+            self.assertIsNone(path)
+
+    def test_nonexistent_double_extension_file_pipeline_finder(self):
+        CUSTOM_FINDERS = settings.STATICFILES_FINDERS + ('pipeline.finders.PipelineFinder',)
+        with self.settings(STATICFILES_FINDERS=CUSTOM_FINDERS):
+            path = finders.find('app.css.map')
+            self.assertIsNone(path)
+
+    def test_nonexistent_double_extension_file_cached_finder(self):
+        CUSTOM_FINDERS = settings.STATICFILES_FINDERS + ('pipeline.finders.CachedFileFinder',)
+        with self.settings(STATICFILES_FINDERS=CUSTOM_FINDERS):
+            path = finders.find('app.css.map')
+            self.assertIsNone(path)