Skip to content

Commit 2e16112

Browse files
committed
Merge branch 'fix-defer-childs-same-polymorphic-parent' into master
2 parents fb80233 + 9500a21 commit 2e16112

File tree

3 files changed

+23
-0
lines changed

3 files changed

+23
-0
lines changed

polymorphic/query.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from collections import defaultdict
99

1010
from django.contrib.contenttypes.models import ContentType
11+
from django.db.models import FieldDoesNotExist
1112
from django.db.models.query import ModelIterable, Q, QuerySet
1213
from django.utils import six
1314

@@ -392,6 +393,10 @@ class self.model, but as a class derived from self.model. We want to re-fetch
392393
# now a superclass of real_concrete_class. Thus it's
393394
# sufficient to just use the field name.
394395
translated_field_name = field.rpartition('___')[-1]
396+
try:
397+
real_concrete_class._meta.get_field(translated_field_name)
398+
except FieldDoesNotExist:
399+
continue
395400
else:
396401
raise
397402

polymorphic/tests/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ class ModelShow2_plain(ModelShow1_plain):
8181

8282

8383
class Base(ShowFieldType, PolymorphicModel):
84+
polymorphic_showfield_deferred = True
8485
field_b = models.CharField(max_length=10)
8586

8687

polymorphic/tests/test_orm.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,23 @@ def test_defer_fields(self):
252252
'<Model2D: id 4, field1 (CharField), field2 (CharField), field3 (CharField), field4 (CharField), '
253253
'deferred[field2,field3,field4,model2a_ptr_id,model2b_ptr_id]>')
254254

255+
ModelX.objects.create(field_b="A1", field_x="A2")
256+
ModelY.objects.create(field_b="B1", field_y="B2")
257+
258+
objects_deferred = Base.objects.defer('ModelY___field_y')
259+
self.assertEqual(repr(objects_deferred[0]),
260+
'<ModelX: id 3, field_b (CharField), field_x (CharField)>')
261+
self.assertEqual(repr(objects_deferred[1]),
262+
'<ModelY: id 4, field_b (CharField), field_y (CharField), deferred[field_y]>')
263+
264+
objects_only = Base.objects.only(
265+
'polymorphic_ctype', 'ModelY___field_y', 'ModelX___field_x',
266+
)
267+
self.assertEqual(repr(objects_only[0]),
268+
'<ModelX: id 3, field_b (CharField), field_x (CharField), deferred[field_b]>')
269+
self.assertEqual(repr(objects_only[1]),
270+
'<ModelY: id 4, field_b (CharField), field_y (CharField), deferred[field_b]>')
271+
255272
def test_defer_related_fields(self):
256273
self.create_model2abcd()
257274

0 commit comments

Comments
 (0)