Skip to content

Commit be374e2

Browse files
morsikjleclanche
authored andcommitted
Fix for broken fix about multi-fields in single line
Fix for error in #539
1 parent bd2ff0b commit be374e2

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

polymorphic/admin/childadmin.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -227,17 +227,18 @@ def get_subclass_fields(self, request, obj=None):
227227

228228
# Find which fields are not part of the common fields.
229229
for fieldset in self.get_base_fieldsets(request, obj):
230-
# multiple elements in single line
231-
if isinstance(field, tuple):
232-
for line_field in field:
230+
for field in fieldset[1]["fields"]:
231+
# multiple elements in single line
232+
if isinstance(field, tuple):
233+
for line_field in field:
234+
try:
235+
subclass_fields.remove(line_field)
236+
except ValueError:
237+
pass # field not found in form, Django will raise exception later.
238+
else:
239+
# regular one-element-per-line
233240
try:
234-
subclass_fields.remove(line_field)
241+
subclass_fields.remove(field)
235242
except ValueError:
236243
pass # field not found in form, Django will raise exception later.
237-
else:
238-
# regular one-element-per-line
239-
try:
240-
subclass_fields.remove(field)
241-
except ValueError:
242-
pass # field not found in form, Django will raise exception later.
243244
return subclass_fields

0 commit comments

Comments
 (0)