Skip to content

Commit 67fe37e

Browse files
azevakinjleclanche
authored andcommitted
qs.send_message refactoring (values_list makes additional sql query)
1 parent 8d913ac commit 67fe37e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

push_notifications/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def send_message(self, message, **kwargs):
3434
if message is not None:
3535
data["message"] = message
3636

37-
reg_ids = list(self.values_list("registration_id", flat=True))
37+
reg_ids = [rec.registration_id for rec in self]
3838
return gcm_send_bulk_message(registration_ids=reg_ids, data=data, **kwargs)
3939

4040

@@ -68,7 +68,7 @@ class APNSDeviceQuerySet(models.query.QuerySet):
6868
def send_message(self, message, **kwargs):
6969
if self:
7070
from .apns import apns_send_bulk_message
71-
reg_ids = list(self.values_list("registration_id", flat=True))
71+
reg_ids = [rec.registration_id for rec in self]
7272
return apns_send_bulk_message(registration_ids=reg_ids, alert=message, **kwargs)
7373

7474

0 commit comments

Comments
 (0)