Testcase and changelog added for issue #724

Author: Saurav Sharma

changelog.d/724.fix

@@ -0,0 +1,3 @@
+Fix for Issue 724(expire method fails when using DEFAULT_TIMEOUT)
+
+https://github.com/jazzband/django-redis/issues/724

django_redis/client/default.py

@@ -299,7 +299,11 @@ def expire(
         version: Optional[int] = None,
         client: Optional[Redis] = None,
     ) -> bool:
-        if timeout is DEFAULT_TIMEOUT:
+        # timeout could be of type int|timedelta
+        # if timeout is DEFAULT_TIMEOUT or None then
+        # use self._backend.default_timeout(django default cache timeout)
+
+        if (timeout is DEFAULT_TIMEOUT) or (timeout is None):
             timeout = self._backend.default_timeout
 
         if client is None:

tests/test_backend.py

@@ -7,6 +7,7 @@
 
 import pytest
 from django.core.cache import caches
+from django.core.cache.backends.base import DEFAULT_TIMEOUT
 from django.test import override_settings
 from pytest_django.fixtures import SettingsWrapper
 from pytest_mock import MockerFixture
@@ -606,6 +607,10 @@ def test_expire(self, cache: RedisCache):
         assert pytest.approx(ttl) == 20
         assert cache.expire("not-existent-key", 20) is False
 
+    def test_expire_with_default_timeout(self, cache: RedisCache):
+        cache.set("foo", "bar", timeout=None)
+        assert cache.expire("foo", DEFAULT_TIMEOUT) is True
+
     def test_pexpire(self, cache: RedisCache):
         cache.set("foo", "bar", timeout=None)
         assert cache.pexpire("foo", 20500) is True